Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to CipherSuitesConverter outside of the io.netty.handler.ssl #11655

Closed
kushalagrawal opened this issue Sep 4, 2021 · 0 comments · Fixed by #11656
Closed

ability to CipherSuitesConverter outside of the io.netty.handler.ssl #11655

kushalagrawal opened this issue Sep 4, 2021 · 0 comments · Fixed by #11656
Milestone
4.1.68.Final

Comments

@kushalagrawal
Copy link
Contributor

In our use case, we are required to convert the java cipher suites are required to be converted to Openssl. I found that netty already has a CipherSuitesConverter. As we are already using netty, we could have reused the class if it was not made the package private. IMO it would be no harm if we make it public to be used for the project using netty already.

I will raise a pull request for the same.
@kushalagrawal kushalagrawal mentioned this issue Sep 4, 2021
Merged
kushalagrawal pushed a commit to kushalagrawal/netty that referenced this issue Sep 6, 2021
Updated "CipherSuitesConverter" to make it public.
6207070 
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes netty#11655
normanmaurer pushed a commit that referenced this issue Sep 6, 2021
Updated "CipherSuitesConverter" to make it public. (#11656)
a329857 
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes #11655
@normanmaurer normanmaurer added this to the 4.1.68.Final milestone Sep 6, 2021
normanmaurer pushed a commit that referenced this issue Sep 6, 2021
@normanmaurer
Updated "CipherSuitesConverter" to make it public. (#11656)
3a23094 
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes #11655
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this issue Dec 16, 2021
@laosijikaichele
Updated "CipherSuitesConverter" to make it public. (netty#11656)
d5e2677 
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes netty#11655
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this issue Dec 16, 2021
@laosijikaichele
Updated "CipherSuitesConverter" to make it public. (netty#11656)
e233684 
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes netty#11655
raidyue pushed a commit to raidyue/netty that referenced this issue Jul 8, 2022
Updated "CipherSuitesConverter" to make it public. (netty#11656)
18430e6 
Motivation:
While using netty there is sometimes need to handle the cipher suites and
signature algorithm in more strict environment. CipherSuiteConverter is
quite helpful in converting Cipher-Suites to and from java to openSSL.
Making it public would be helpful for the project which are using netty.

Modification:
Updated "CipherSuitesConverter" to make it public.
updated "CipherSuitesConverter.toOpenssl" to public.
updated "CipherSuitesConverter.toJava" to public.

Result:
Fixes netty#11655
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.68.Final
Development

Successfully merging a pull request may close this issue.

Updated "CipherSuitesConverter" to make it public. kushalagrawal/netty
2 participants
@normanmaurer @kushalagrawal