Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ReferenceCounted to common #1441

Closed
normanmaurer opened this issue Jun 12, 2013 · 4 comments
Closed

Move ReferenceCounted to common #1441

normanmaurer opened this issue Jun 12, 2013 · 4 comments
Assignees
@trustin
Labels
cleanup
Milestone
4.0.0.CR4

Comments

@normanmaurer
Copy link
Member

I think we should move ReferenceCounted (and abstract impls) to common as it is not really something that specific to buffers.

@trustin WDYT ?
@trustin
Copy link
Member

trustin commented Jun 13, 2013

I also had to move IllegalBufferAccessException. Renamed it to ReferenceCountException which sounds better.

@ghost ghost assigned trustin Jun 13, 2013
@normanmaurer
Copy link
Member Author

I think IllegalReferenceAccessException would explain better why it's theown.

@trustin WDYT

Am 13.06.2013 um 06:15 schrieb Trustin Lee notifications@github.com:

I also had to move IllegalBufferAccessException. Renamed it to ReferenceCountException which sounds better.

—
Reply to this email directly or view it on GitHub.

@trustin
Copy link
Member

trustin commented Jun 13, 2013

IllegalReferenceCountException?

@normanmaurer
Copy link
Member Author

@trustin +1

hackmann pushed a commit to hackmann/netty that referenced this issue Jan 14, 2016
@trustin @hkampbjorn
Move ReferenceCounted and AbstractReferenceCounted to io.netty.util
dc6d8e7 
- Fixes netty#1441
- Also move and rename IllegalBufferAccessException to ReferenceCountException
- Prettier reference count exception messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trustin trustin

Labels
cleanup
Projects
None yet
Milestone
4.0.0.CR4
Development

No branches or pull requests
2 participants
@trustin @normanmaurer