Resource Leak

[md-5]

This is impossible to occur as its happening in the write() pipeline.....?

[SEVERE] Jul 19, 2013 6:38:29 PM io.netty.util.ResourceLeakDetector reportLeak
WARNING: LEAK: ByteBuf was GC'd before being released correctly. The following stack trace shows where the leaked object was created, rather than where you failed to release it.
io.netty.util.ResourceLeakException: io.netty.buffer.UnpooledUnsafeDirectByteBuf@50b5345
at io.netty.util.ResourceLeakDetector$DefaultResourceLeak.(ResourceLeakDetector.java:161)
at io.netty.util.ResourceLeakDetector.open(ResourceLeakDetector.java:103)
at io.netty.buffer.UnpooledUnsafeDirectByteBuf.(UnpooledUnsafeDirectByteBuf.java:72)
at io.netty.buffer.UnpooledByteBufAllocator.newDirectBuffer(UnpooledByteBufAllocator.java:49)
at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:130)
at io.netty.buffer.AbstractByteBufAllocator.directBuffer(AbstractByteBufAllocator.java:121)
at io.netty.buffer.AbstractByteBufAllocator.ioBuffer(AbstractByteBufAllocator.java:74)
at io.netty.handler.codec.MessageToByteEncoder.write(MessageToByteEncoder.java:107)
at io.netty.channel.DefaultChannelHandlerContext.invokeWrite0(DefaultChannelHandlerContext.java:698)
at io.netty.channel.DefaultChannelHandlerContext.invokeWrite(DefaultChannelHandlerContext.java:684)
at io.netty.channel.DefaultChannelHandlerContext.write(DefaultChannelHandlerContext.java:677)
at io.netty.handler.codec.MessageToMessageEncoder.write(MessageToMessageEncoder.java:102)
at io.netty.channel.DefaultChannelHandlerContext.invokeWrite0(DefaultChannelHandlerContext.java:698)
at io.netty.channel.DefaultChannelHandlerContext.invokeWrite(DefaultChannelHandlerContext.java:684)
at io.netty.channel.DefaultChannelHandlerContext.write(DefaultChannelHandlerContext.java:677)
at io.netty.channel.DefaultChannelHandlerContext.write(DefaultChannelHandlerContext.java:668)
at io.netty.channel.DefaultChannelPipeline.write(DefaultChannelPipeline.java:873)
at io.netty.channel.AbstractChannel.write(AbstractChannel.java:230)
at net.md_5.bungee.netty.ChannelWrapper.write(ChannelWrapper.java:26)
at net.md_5.bungee.ServerConnection$1.sendPacket(ServerConnection.java:30)
at net.md_5.bungee.ServerConnection.disconnect(ServerConnection.java:46)
at net.md_5.bungee.UserConnection.disconnect(UserConnection.java:252)
at net.md_5.bungee.connection.DownstreamBridge.disconnected(DownstreamBridge.java:69)
at net.md_5.bungee.netty.HandlerBoss.channelInactive(HandlerBoss.java:54)
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelInactive(DefaultChannelHandlerContext.java:263)
at io.netty.channel.DefaultChannelHandlerContext.fireChannelInactive(DefaultChannelHandlerContext.java:249)
at io.netty.handler.codec.ReplayingDecoder.channelInactive(ReplayingDecoder.java:346)
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelInactive(DefaultChannelHandlerContext.java:263)
at io.netty.channel.DefaultChannelHandlerContext.fireChannelInactive(DefaultChannelHandlerContext.java:249)
at io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:75)
at io.netty.handler.timeout.ReadTimeoutHandler.channelInactive(ReadTimeoutHandler.java:143)
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelInactive(DefaultChannelHandlerContext.java:263)
at io.netty.channel.DefaultChannelHandlerContext.fireChannelInactive(DefaultChannelHandlerContext.java:249)
at io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:762)
at io.netty.channel.AbstractChannel$AbstractUnsafe$4.run(AbstractChannel.java:530)
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:353)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:366)
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101)
at java.lang.Thread.run(Unknown Source)

[normanmaurer]

Please show me the "MessageToByteEncoder" you have in the pipeline.

[md-5]

https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/netty/CipherEncoder.java (https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/netty/CipherBase.java)

And
https://github.com/SpigotMC/BungeeCord/blob/master/proxy/src/main/java/net/md_5/bungee/netty/DefinedPacketEncoder.java

And also the standard netty ByteArrayEncoder

[normanmaurer]

@md-5 could you re-try with latest 4.0.4-SNAPSHOT. i think I just fixed it via 81612f8 .

[normanmaurer]

Please re-open if you still see the issue @md-5