New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpMessageEncoder should add Header "Transfer-Encoding: chunked" if HttpMessage.isChunked() #171
Comments
@trustin As this is kind of not backward compatible, do we also want to have it in 3.3.x ? |
We should also adjust the javadocs in HttpMessage then... |
It's an expected behavior. HttpMessageDecoder splits the content into multiple HttpChunks and calls setChunked(true) if the content length is large. It doesn't necessarily mean that the HTTP message's encoding is chunked. But yeah, it's better document this behavior more clearly. |
Thats true here.. but what about if you use it for HttpResponse's ? I think there it makes sense.. |
Oh I see. Then what about modifying HttpMessageEncoder so that it sets the Transfer-encoding header if HttpMessage.isChunked() is true (unless it's set already)? |
Yeah.. That will make most sense I guess... Let me do it and also make things more clear in the apidocs. |
HttpMessage.isChunked(). See #171
if HttpMessage.isChunked(). See #171
Ok the HttpMessageEncoder does now add the header if its not present. |
If HttpMessage.getChunked() is true, we should make sure we also add the "Transfer-Encoding: chunked" header to the message if its not already present. This should be what the user / dev does also expect here.
The text was updated successfully, but these errors were encountered: