Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epoll transport fails on gathering write of more then 1024 buffers #2647

Closed
normanmaurer opened this issue Jul 9, 2014 · 0 comments
Closed

epoll transport fails on gathering write of more then 1024 buffers #2647

normanmaurer opened this issue Jul 9, 2014 · 0 comments
Assignees
@normanmaurer
Labels
defect
Milestone
4.0.22.Final

Comments

@normanmaurer
Copy link
Member

As linux supports max. 1024 iov entries when calling writev(...) the epoll transport throws an exception.

See:
http://linux.die.net/man/2/writev
@normanmaurer normanmaurer added this to the 4.0.22.Final milestone Jul 9, 2014
normanmaurer pushed a commit that referenced this issue Jul 9, 2014
[#2647] Respect IOV_MAX when call writev in native transport
578068c 
Motivation:

epoll transport fails on gathering write of more then 1024 buffers. As linux supports max. 1024 iov entries when calling writev(...) the epoll transport throws an exception.

Thanks again to @blucas to provide me with a reproducer and so helped me to understand what the issue is.

Modifications:

Make sure we break down the writes if to many buffers are uses for gathering writes.

Result:

Gathering writes work with any number of buffers
normanmaurer pushed a commit that referenced this issue Jul 9, 2014
[#2647] Respect IOV_MAX when call writev in native transport
fb22d34 
Motivation:

epoll transport fails on gathering write of more then 1024 buffers. As linux supports max. 1024 iov entries when calling writev(...) the epoll transport throws an exception.

Thanks again to @blucas to provide me with a reproducer and so helped me to understand what the issue is.

Modifications:

Make sure we break down the writes if to many buffers are uses for gathering writes.

Result:

Gathering writes work with any number of buffers
normanmaurer pushed a commit that referenced this issue Jul 9, 2014
[#2647] Respect IOV_MAX when call writev in native transport
b440fa8 
Motivation:

epoll transport fails on gathering write of more then 1024 buffers. As linux supports max. 1024 iov entries when calling writev(...) the epoll transport throws an exception.

Thanks again to @blucas to provide me with a reproducer and so helped me to understand what the issue is.

Modifications:

Make sure we break down the writes if to many buffers are uses for gathering writes.

Result:

Gathering writes work with any number of buffers
normanmaurer pushed a commit that referenced this issue Jul 9, 2014
Fix JVM segfault during JNI call. Part of [#2647]
62bbd42 
Motivation:
Currently when Native.writev(...) is used it is possible to see a JVM segfault because the offset is updated to early.

Modification:
Only update the offset once it is safe to do so.

Result:
No more segfault
normanmaurer pushed a commit that referenced this issue Jul 9, 2014
Fix JVM segfault during JNI call. Part of [#2647]
6b71089 
Motivation:
Currently when Native.writev(...) is used it is possible to see a JVM segfault because the offset is updated to early.

Modification:
Only update the offset once it is safe to do so.

Result:
No more segfault
normanmaurer pushed a commit that referenced this issue Jul 17, 2014
[#2647] Handle IOV_MAX in java code
db79012 
Motivation:

The handling of IOV_MAX was done in JNI code base which makes stuff really complicated to maintain etc.

Modifications:

Move handling of IOV_MAX to java code to simplify stuff

Result:

Cleaner code.
normanmaurer pushed a commit that referenced this issue Jul 18, 2014
[#2647] Handle IOV_MAX in java code
4db6c65 
Motivation:

The handling of IOV_MAX was done in JNI code base which makes stuff really complicated to maintain etc.

Modifications:

Move handling of IOV_MAX to java code to simplify stuff

Result:

Cleaner code.
normanmaurer pushed a commit that referenced this issue Jul 18, 2014
[#2647] Handle IOV_MAX in java code
dfa0050 
Motivation:

The handling of IOV_MAX was done in JNI code base which makes stuff really complicated to maintain etc.

Modifications:

Move handling of IOV_MAX to java code to simplify stuff

Result:

Cleaner code.
@normanmaurer normanmaurer self-assigned this Aug 14, 2014
pulllock pushed a commit to pulllock/netty that referenced this issue Oct 19, 2023
[netty#2647] Respect IOV_MAX when call writev in native transport
a6ff521 
Motivation:

epoll transport fails on gathering write of more then 1024 buffers. As linux supports max. 1024 iov entries when calling writev(...) the epoll transport throws an exception.

Thanks again to @blucas to provide me with a reproducer and so helped me to understand what the issue is.

Modifications:

Make sure we break down the writes if to many buffers are uses for gathering writes.

Result:

Gathering writes work with any number of buffers
pulllock pushed a commit to pulllock/netty that referenced this issue Oct 19, 2023
[netty#2647] Handle IOV_MAX in java code
4d000e2 
Motivation:

The handling of IOV_MAX was done in JNI code base which makes stuff really complicated to maintain etc.

Modifications:

Move handling of IOV_MAX to java code to simplify stuff

Result:

Cleaner code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
defect
Projects
None yet
Milestone
4.0.22.Final
Development

No branches or pull requests
1 participant
@normanmaurer