-
-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SslHandler treat OpenSslEngine specially for maximum performance. #3318
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related: #3299
In
SslHandler
, we have a couple places that checks if the current engine isOpenSslEngine
so that we can invoke some non-standard operations inOpenSslEngine
for better performance.However, the non-standard operations still require
SslHandler
to pass NIOByteBuffer
s. We don't really need to enforce this restriction.For example,
OpenSslEngine
could acceptByteBuf
andCompositeByteBuf
rather than NIO buffers, and thus avoid the unnecessary instantiation of NIO buffers.The text was updated successfully, but these errors were encountered: