Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SslHandler treat OpenSslEngine specially for maximum performance. #3318

Open
trustin opened this issue Jan 9, 2015 · 0 comments
Open
Assignees

Comments

@trustin
Copy link
Member

trustin commented Jan 9, 2015

Related: #3299

In SslHandler, we have a couple places that checks if the current engine is OpenSslEngine so that we can invoke some non-standard operations in OpenSslEngine for better performance.

However, the non-standard operations still require SslHandler to pass NIO ByteBuffers. We don't really need to enforce this restriction.

For example, OpenSslEngine could accept ByteBuf and CompositeByteBuf rather than NIO buffers, and thus avoid the unnecessary instantiation of NIO buffers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants