Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example code in ByteBuf 4.0 javadoc uses 3.x API #3899

Closed
justinjhendrick opened this issue Jun 18, 2015 · 5 comments
Closed

Example code in ByteBuf 4.0 javadoc uses 3.x API #3899

justinjhendrick opened this issue Jun 18, 2015 · 5 comments
Assignees
@normanmaurer
Labels
documentation
Milestone
4.0.30.Final

Comments

@justinjhendrick
Copy link

https://netty.io/4.0/api/io/netty/buffer/ByteBuf.html

// Iterates the readable bytes of a buffer.
ByteBuf buffer = ...;
while (buffer.readable()) {
System.out.println(buffer.readByte());
}

But readable() was changed to isReadable() in 4.0
@normanmaurer
Copy link
Member

@justinjhendrick yep... We love PR's, maybe you want to submit one ?

@normanmaurer normanmaurer added this to the 4.0.29.Final milestone Jun 18, 2015
@justinjhendrick
Copy link
Author

I'd like to but my company doesn't want to go through the analysis required for me to contribute to netty for such a small PR. Sorry.

@normanmaurer
Copy link
Member

@justinjhendrick no worries... I will fix it

@normanmaurer normanmaurer self-assigned this Jun 19, 2015
@justinjhendrick
Copy link
Author

Thanks!

normanmaurer added a commit that referenced this issue Jul 3, 2015
@normanmaurer
[#3899] Fix javadoc to use netty 4 API.
d461506 
Motivation:

The javadoc of ByteBuf contained some out-dated code.

Modifications:

Update code example in javadoc to use netty 4+ API

Result:

Correct javadocs
normanmaurer added a commit that referenced this issue Jul 3, 2015
@normanmaurer
[#3899] Fix javadoc to use netty 4 API.
75bb788 
Motivation:

The javadoc of ByteBuf contained some out-dated code.

Modifications:

Update code example in javadoc to use netty 4+ API

Result:

Correct javadocs
normanmaurer added a commit that referenced this issue Jul 3, 2015
@normanmaurer
[#3899] Fix javadoc to use netty 4 API.
8c90d60 
Motivation:

The javadoc of ByteBuf contained some out-dated code.

Modifications:

Update code example in javadoc to use netty 4+ API

Result:

Correct javadocs
normanmaurer added a commit that referenced this issue Jul 3, 2015
@normanmaurer
[#3899] Fix javadoc to use netty 4 API.
95dba82 
Motivation:

The javadoc of ByteBuf contained some out-dated code.

Modifications:

Update code example in javadoc to use netty 4+ API

Result:

Correct javadocs
@normanmaurer
Copy link
Member

Fixed

pulllock pushed a commit to pulllock/netty that referenced this issue Oct 19, 2023
@normanmaurer
[netty#3899] Fix javadoc to use netty 4 API.
e02350a 
Motivation:

The javadoc of ByteBuf contained some out-dated code.

Modifications:

Update code example in javadoc to use netty 4+ API

Result:

Correct javadocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
documentation
Projects
None yet
Milestone
4.0.30.Final
Development

No branches or pull requests
2 participants
@normanmaurer @justinjhendrick