Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow writing long-length objects in HTTP/2 flow control #4283

Closed
nmittler opened this issue Sep 25, 2015 · 2 comments
Closed

Allow writing long-length objects in HTTP/2 flow control #4283

nmittler opened this issue Sep 25, 2015 · 2 comments
Assignees
@Scottmitch
Labels
feature
Milestone
4.1.20.Final

Comments

@nmittler
Copy link
Member

This is just to capture the data byte we use for streamableBytes. It should be changed to long to support very large objects (e.g. FileRegion).

@Scottmitch FYI
@Scottmitch
Copy link
Member

@nmittler - So you are thinking that each stream's pendingBytes should be of data type long (and then what ever else needs to change to accommodate this)?

@nmittler
Copy link
Member Author

@Scottmitch yeah that's basically it (for now). The writableBytes would still be an int, but streams may have more than MAX_INT to send.

@Apache9 Apache9 mentioned this issue Jul 19, 2017
Open
This was referenced Dec 15, 2017
Open
Closed
@Scottmitch Scottmitch self-assigned this Dec 19, 2017
@Scottmitch Scottmitch added this to the 4.1.20.Final milestone Dec 19, 2017
@Scottmitch Scottmitch mentioned this issue Dec 19, 2017
Merged
Scottmitch added a commit to Scottmitch/netty that referenced this issue Dec 19, 2017
@Scottmitch
HTTP/2 support pending data larger than Integer.MAX_VALUE
369607e 
Motivation:
Currently the remote flow controller limits the maximum amount of pending data to Integer.MAX_VALUE. The overflow handling is also not very graceful in that it may lead to infinite loops, or otherwise no progress being made.

Modifications:
- StreamByteDistributor and RemoteFlowController should support pending bytes of type long.

Result:
Fixes netty#4283
Scottmitch added a commit that referenced this issue Dec 20, 2017
@Scottmitch
HTTP/2 support pending data larger than Integer.MAX_VALUE
144716f 
Motivation:
Currently the remote flow controller limits the maximum amount of pending data to Integer.MAX_VALUE. The overflow handling is also not very graceful in that it may lead to infinite loops, or otherwise no progress being made.

Modifications:
- StreamByteDistributor and RemoteFlowController should support pending bytes of type long.

Result:
Fixes #4283
kiril-me pushed a commit to kiril-me/netty that referenced this issue Feb 28, 2018
@Scottmitch @kiril-me
HTTP/2 support pending data larger than Integer.MAX_VALUE
0f1a205 
Motivation:
Currently the remote flow controller limits the maximum amount of pending data to Integer.MAX_VALUE. The overflow handling is also not very graceful in that it may lead to infinite loops, or otherwise no progress being made.

Modifications:
- StreamByteDistributor and RemoteFlowController should support pending bytes of type long.

Result:
Fixes netty#4283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottmitch Scottmitch

Labels
feature
Projects
None yet
Milestone
4.1.20.Final
Development

No branches or pull requests
2 participants
@nmittler @Scottmitch