StackOverflowError when adding listener to DefaultPromise w/ ImmediateEventExecutor

[maxwindiff]

This will produce a StackOverflowError:

    @Test
    public void testName() throws Exception {
        DefaultPromise<Object> promise = new DefaultPromise<>(ImmediateEventExecutor.INSTANCE);
        promise.addListener(f1 -> {
            promise.addListener(f2 -> System.out.println("done"));
        });
        promise.tryFailure(new Exception());
    }

The error may not show up in console but if you add an exception breakpoint in IntelliJ / Eclipse you'll see it.

Reproduces on 4.1.0.Beta7

[Scottmitch]

thanks for reporting @maxwindiff!

[buchgr]

@Scottmitch Does this also fix #3450?

[normanmaurer]

@buchgr yes I think so.

[Scottmitch]

@buchgr - Based upon your description (same scenario that is described in this issue), I would think this should take care of #3450. Is it possible to verify?

[buchgr]

@Scottmitch I don't have the code anymore, but yeah it looks like it fixes both issues. I think it's a perfectly valid fix as it makes it work with all Netty provided Executors. However, it doesn't work with Guava's DirectExecutor or Developer Joes SelfBakedDirectExecutor :). I couldn't think of fix for those scenarios myself either ...

[Scottmitch]

@buchgr - I also couldn't think of a good way to generalize the behavior of the executor will always (or on the next execute call) use the same thread to execute tasks. ... and just punted for the near term :(