Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in AbstractMemcacheObjectEncoder with FullMemcacheMessage(s) #5197

Closed
rkapsi opened this issue May 2, 2016 · 2 comments
Closed

Bug in AbstractMemcacheObjectEncoder with FullMemcacheMessage(s) #5197

rkapsi opened this issue May 2, 2016 · 2 comments
Assignees
@Scottmitch
Labels
defect
Milestone
4.1.0.Final

Comments

@rkapsi
Copy link
Member

rkapsi commented May 2, 2016

Netty 4.1.0-SNAPSHOT

There is a bug in AbstractMemcacheObjectEncoder on line 48.

The encode() method returns and the FullBinaryMemcacheRequest|Response content() gets never written.
@Scottmitch
Copy link
Member

@rkapsi - Thanks for reporting!

@Scottmitch Scottmitch added this to the 4.1.0.Final milestone May 2, 2016
@Scottmitch Scottmitch self-assigned this May 2, 2016
@Scottmitch
Copy link
Member

Trivial fix to revert a commit see .. 9ed2f01

If issue still persists please re-open.

windie added a commit to windie/netty that referenced this issue May 3, 2016
@windie
Add regression tests for FullMemcacheMessageRequest and FullMemcacheM…
1a47f4f 
…essageResponse

Motivation:

It's better to have some tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse to avoid regression like netty#5197.

Modifications:

Add tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse.

Result:

There are some basic tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse.
@windie windie mentioned this issue May 3, 2016
Closed
normanmaurer pushed a commit that referenced this issue May 3, 2016
@windie @normanmaurer
Add regression tests for FullMemcacheMessageRequest and FullMemcacheM…
a974fff 
…essageResponse

Motivation:

It's better to have some tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse to avoid regression like #5197.

Modifications:

Add tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse.

Result:

There are some basic tests for FullMemcacheMessageRequest and FullMemcacheMessageResponse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Scottmitch Scottmitch

Labels
defect
Projects
None yet
Milestone
4.1.0.Final
Development

No branches or pull requests
2 participants
@rkapsi @Scottmitch