Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows build fails as default hosts file is empty #5868

Closed
radai-rosenblatt opened this issue Sep 28, 2016 · 2 comments
Closed

Windows build fails as default hosts file is empty #5868

radai-rosenblatt opened this issue Sep 28, 2016 · 2 comments
Assignees
@normanmaurer
Milestone
4.1.7.Final

Comments

@radai-rosenblatt
Copy link
Contributor

DefaultHostsFileEntriesResolverTest relies on DefaultHostsFileEntriesResolver parsing the hosts file on creation. on windows this file is C:\Windows\System32\drivers\etc\hosts and (at least on win7, probably others) its empty, while the test assumes the hosts file contains an entry for localhost.

see this ServerFault link for more details - http://serverfault.com/questions/4689/windows-7-localhost-name-resolution-is-handled-within-dns-itself-why
@Scottmitch
Copy link
Member

fixed by #5869

@normanmaurer
Copy link
Member

Fixed by #5869

@normanmaurer normanmaurer self-assigned this Nov 21, 2016
@normanmaurer normanmaurer added this to the 4.1.7.Final milestone Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
None yet
Projects
None yet
Milestone
4.1.7.Final
Development

No branches or pull requests
3 participants
@normanmaurer @radai-rosenblatt @Scottmitch