Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http2FrameCodecTest use of spy for mocking #6036

Closed
Scottmitch opened this issue Nov 18, 2016 · 2 comments · Fixed by #8646
Closed

Http2FrameCodecTest use of spy for mocking #6036

Scottmitch opened this issue Nov 18, 2016 · 2 comments · Fixed by #8646
Assignees
@normanmaurer
Labels
cleanup
Milestone
4.1.33.Final

Comments

@Scottmitch
Copy link
Member

Scottmitch commented Nov 18, 2016 •
edited
Loading

Using spy() from mocking can cause exceptions to be thrown while stepping through and debugging a test. This can prevent from debugging and create a makings distinguishing between real issues and mocking framework issues difficult. We should consider not using spy() or work with the mocking folks to identify the root cause.

#5996 (comment)
@Scottmitch
Copy link
Member Author

@buchgr @normanmaurer /cc

@Scottmitch Scottmitch mentioned this issue Nov 18, 2016
Closed
@normanmaurer
Copy link
Member

@Scottmitch I will take a crack on this....

@normanmaurer normanmaurer self-assigned this Nov 18, 2016
@normanmaurer normanmaurer added this to the 4.0.43.Final milestone Nov 18, 2016
@Scottmitch Scottmitch mentioned this issue Mar 9, 2017
Closed
@normanmaurer normanmaurer mentioned this issue Dec 10, 2018
Merged
normanmaurer added a commit that referenced this issue Dec 10, 2018
@normanmaurer
Cleanup HTTP/2 tests for Http2FrameCodec and Http2MultiplexCodec
09fe6b0 
Motiviation:

Http2FrameCodecTest and Http2MultiplexCodecTest were quite fragile and often not went through the whole pipeline which made testing sometimes hard and error-prone.

Modification:

- Refactor tests to have data flow through the whole pipeline and so made the test more robust (by testing the while implementation).

Result:

Easier to write tests for the codecs in the future and more robust testing in general.

Beside this it also fixes #6036.
normanmaurer added a commit that referenced this issue Dec 14, 2018
@normanmaurer
Cleanup HTTP/2 tests for Http2FrameCodec and Http2MultiplexCodec (#8646)
05d481d 
Motiviation:

Http2FrameCodecTest and Http2MultiplexCodecTest were quite fragile and often not went through the whole pipeline which made testing sometimes hard and error-prone.

Modification:

- Refactor tests to have data flow through the whole pipeline and so made the test more robust (by testing the while implementation).

Result:

Easier to write tests for the codecs in the future and more robust testing in general.

Beside this it also fixes #6036.
@normanmaurer normanmaurer added this to the 4.1.33.Final milestone Dec 27, 2018
normanmaurer added a commit that referenced this issue Dec 28, 2018
@normanmaurer
Cleanup HTTP/2 tests for Http2FrameCodec and Http2MultiplexCodec (#8646)
fa84e2b 
Motiviation:

Http2FrameCodecTest and Http2MultiplexCodecTest were quite fragile and often not went through the whole pipeline which made testing sometimes hard and error-prone.

Modification:

- Refactor tests to have data flow through the whole pipeline and so made the test more robust (by testing the while implementation).

Result:

Easier to write tests for the codecs in the future and more robust testing in general.

Beside this it also fixes #6036.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
cleanup
Projects
None yet
Milestone
4.1.33.Final
Development

Successfully merging a pull request may close this issue.

Cleanup HTTP/2 tests for Http2FrameCodec and Http2MultiplexCodec netty/netty
2 participants
@normanmaurer @Scottmitch