JDKZlibEncoder or JDKZlibDecoder can't work correct with large data

[lsqlebai]

Expected behavior

work

Actual behavior

decode error(protobuf decode error)

Steps to reproduce

i have 2 server. and them communicate with tcp.
and the pipeline init code double with them.
when the send data > 16000 byte (maybe less). the decode side can't correct decode (protobuf decode error).

Minimal yet complete reproducer code (or URL to code)

decode error code:
Code:

    ChannelPipeline pipeline = ch.pipeline();
    pipeline.addLast(new ProtobufVarint32FrameDecoder());
    pipeline.addLast(ZlibCodecFactory.newZlibDecoder(ZlibWrapper.NONE));
    pipeline.addLast(new ProtobufDecoder(GameServer.ServerData.getDefaultInstance()));
    pipeline.addLast(new ProtobufVarint32LengthFieldPrepender());
    pipeline.addLast(ZlibCodecFactory.newZlibEncoder(ZlibWrapper.NONE));
    pipeline.addLast(new ProtobufEncoder());

i had 2 test:
remove zlib, can be work.like this:

  ChannelPipeline pipeline = ch.pipeline();
    //receive
    pipeline.addLast(new ProtobufVarint32FrameDecoder());
    pipeline.addLast(new ProtobufDecoder(GameServer.ServerData.getDefaultInstance()));
    //send
    pipeline.addLast(new ProtobufVarint32LengthFieldPrepender());
    pipeline.addLast(new ProtobufEncoder());

change to the JZlibDecoder and JZlibEncoder can be work. like this:

    ChannelPipeline pipeline = ch.pipeline();
    //receive
    pipeline.addLast(new ProtobufVarint32FrameDecoder());
    pipeline.addLast(new JZlibDecoder(ZlibWrapper.NONE));
    pipeline.addLast(new ProtobufDecoder(GameServer.ServerData.getDefaultInstance()));
    //send
    pipeline.addLast(new ProtobufVarint32LengthFieldPrepender());
    pipeline.addLast(new JZlibEncoder(ZlibWrapper.NONE));
    pipeline.addLast(new ProtobufEncoder());

Netty version

4.1.7

JVM version (e.g. java -version)

java version "1.8.0_101"

OS version (e.g. uname -a)

windows

[normanmaurer]

@lsqlebai can you please provide a full reproducer ? Also please update to latest netty version just to be sure.

[lsqlebai]

sorry the netty version is 4.1.6.Final

[lsqlebai]

@normanmaurer What would you want? my project is so large. maybe i can give u a demo when i free.

[normanmaurer]

@lsqlebai I want you to upgrade to latest 4.1. version and try again if it happens. If it still happens provide me some way to reproduce.

[Scottmitch]

my project is so large. maybe i can give u a demo when i free.

Ideally folks that file issues will provide a minimal/complete (so we can run it, but don't have to understand your entire application logic) ... the easier it is to reproduce the more likely we will be able to figure out the issue (assuming its a Netty issue) and fix it.

[lsqlebai]

@Scottmitch @normanmaurer i wrote a demo, how can i give you? by email or???

[lsqlebai]

@Scottmitch @normanmaurer would u please try this code: https://github.com/lsqlebai/testzlib
that can be reproduce .

[Scottmitch]

I took a brief look. It seems like the issue is in this case the JdkZlibDecoder happens to break the decode up into 2 buffers and the JZlibDecoder decodes into a single buffer, and the ProtobufDecoder#decoder assumes all content is in the same ByteBuf. See #6816 for a PR which makes the two decoders consistent.