Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LocalChannel / LocalServerChannel not respect ChannelOption. MAX_MESSAGES_PER_READ #7880

Closed
normanmaurer opened this issue Apr 19, 2018 · 2 comments
Closed

LocalChannel / LocalServerChannel not respect ChannelOption. MAX_MESSAGES_PER_READ #7880

normanmaurer opened this issue Apr 19, 2018 · 2 comments
Assignees
@normanmaurer
Labels
defect
Milestone
4.1.25.Final

Comments

@normanmaurer
Copy link
Member

normanmaurer commented Apr 19, 2018 •
edited
Loading

LocalChannel / LocalServerChannel not respect ChannelOption.MAX_MESSAGES_PER_READ and just keeps processing messages until there are no more present.
@KowalczykBartek
Copy link
Contributor

@normanmaurer do you mean MAX_MESSAGES_PER_READ in netty-5.0.0.Alpha ?

@normanmaurer
Copy link
Member Author

Ups yes https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/ChannelOption.java#L83

@normanmaurer normanmaurer changed the title LocalChannel / LocalServerChannel not respect ChannelOption.MAX_MESSAGES_READ LocalChannel / LocalServerChannel not respect ChannelOption. MAX_MESSAGES_PER_READ Apr 19, 2018
@normanmaurer normanmaurer mentioned this issue Apr 23, 2018
Merged
normanmaurer added a commit that referenced this issue Apr 23, 2018
@normanmaurer
Respect MAX_MESSAGES_PER_READ in LocalChannel / LocalServerChannel.
5d69b10 
Motivation:

LocalChannel / LocalServerChannel did not respect read limits and just always read all of the messages.

Modifications:

- Correct respect MAX_MESSAGES_PER_READ settings
- Add unit tests

Result:

Fixes #7880.
@normanmaurer normanmaurer self-assigned this Apr 23, 2018
@normanmaurer normanmaurer added this to the 4.1.25.Final milestone Apr 23, 2018
normanmaurer added a commit that referenced this issue Apr 26, 2018
@normanmaurer
Respect MAX_MESSAGES_PER_READ in LocalChannel / LocalServerChannel. (#…
f4d7e8d 
…7885)

Motivation:

LocalChannel / LocalServerChannel did not respect read limits and just always read all of the messages.

Modifications:

- Correct respect MAX_MESSAGES_PER_READ settings
- Add unit tests

Result:

Fixes #7880.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
defect
Projects
None yet
Milestone
4.1.25.Final
Development

No branches or pull requests
2 participants
@normanmaurer @KowalczykBartek