Http2Headers pseudoheader setting methods incorrectly documented

[mosesn]

Here in the docs it says the setter sets the header conditionally, but it seems to actually be unconditional.

Docs:

    /**
     * Sets the {@link PseudoHeaderName#METHOD} header or {@code null} if there is no such header
     */
    Http2Headers method(CharSequence value);

Implementation:

    @Override
    public Http2Headers method(CharSequence value) {
        set(PseudoHeaderName.METHOD.value(), value);
        return this;
    }

One of these is wrong, but I don't know which one it is.

[normanmaurer]

@Scottmitch @trustin thoughts ?

[normanmaurer]

@trustin @ejona86 @carl-mastrangelo @Scottmitch ping...

[carl-mastrangelo]

Looks like a typo. The blame line shows that being present for a while. I'm not sure what the docs mean: Does it clear the header if it doesnt exist? Does it clear it if it doesn't apply (such as in a response header)? I would support making the doc take no position on the matter.

[ejona86]

The doc does seem wrong. Null doesn't even make sense in that context. Seems it should be "Sets the {@link PseudoHeaderName#METHOD} header".

[normanmaurer]

@ejona86 want to do a PR ?