Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpMultiplexCodec writability #8148

Closed
Scottmitch opened this issue Jul 24, 2018 · 0 comments · Fixed by #9235
Closed

HttpMultiplexCodec writability #8148

Scottmitch opened this issue Jul 24, 2018 · 0 comments · Fixed by #9235
Milestone
4.1.37.Final

Comments

@Scottmitch
Copy link
Member

There are a number of TODO statements related to writability in the h2 child channel implementation. We should investigate how to make the existing channel API's writability (isWritable(), writabilityChanged(), bytesBeforeWritable(), bytesBeforeUnwritable(), writing outside the event loop) with flow control and other restrictions of the existing implementation.
@Scottmitch Scottmitch mentioned this issue Jul 24, 2018
Merged
This was referenced May 4, 2019
Closed
Closed
normanmaurer added a commit that referenced this issue May 6, 2019
@normanmaurer
Implement Http2StreamChannel.bytesBeforeWritable() and bytesBeforeUnw…
ea68dcf 
…ritable()

Motivation:

Our Http2StreamChannel implementation did not implement bytesBeforeWritable() and bytesBeforeUnwritable(). We should implement these to make the channel implementation more feature complete.

Modifications:

- Implement both methods
- Update tests to cover the implementations.

Result:

Fixes #8148.
@normanmaurer normanmaurer mentioned this issue May 6, 2019
Closed
normanmaurer added a commit that referenced this issue Jun 12, 2019
@normanmaurer
Writability state of http2 child channels should be decoupled from th…
18a2738 
…e flow-controller

Motivation:

We should decouple the writability state of the http2 child channels from the flow-controller and just tie it to its own pending bytes counter that is decremented by the parent Channel once the bytes were written.

Modifications:

- Decouple writability state of child channels from flow-contoller
- Update tests

Result:

Less coupling and more correct behavior. Fixes #8148.
@normanmaurer normanmaurer mentioned this issue Jun 12, 2019
Merged
@normanmaurer normanmaurer added this to the 4.1.37.Final milestone Jun 12, 2019
normanmaurer added a commit that referenced this issue Jun 18, 2019
@normanmaurer
Writability state of http2 child channels should be decoupled from th…
f945a07 
…e flow-controller (#9235)

Motivation:

We should decouple the writability state of the http2 child channels from the flow-controller and just tie it to its own pending bytes counter that is decremented by the parent Channel once the bytes were written.

Modifications:

- Decouple writability state of child channels from flow-contoller
- Update tests

Result:

Less coupling and more correct behavior. Fixes #8148.
normanmaurer added a commit that referenced this issue Jun 18, 2019
@normanmaurer
Writability state of http2 child channels should be decoupled from th…
aaf5ec1 
…e flow-controller (#9235)

Motivation:

We should decouple the writability state of the http2 child channels from the flow-controller and just tie it to its own pending bytes counter that is decremented by the parent Channel once the bytes were written.

Modifications:

- Decouple writability state of child channels from flow-contoller
- Update tests

Result:

Less coupling and more correct behavior. Fixes #8148.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.37.Final
2 participants
@normanmaurer @Scottmitch