CleanerJava9 should be able to do its job even with a SecurityManager… #8204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… installed. Motivation: CleanerJava9 currently fails whever a SecurityManager is installed. We should make use of AccessController.doPrivileged(...) so the user can give it the correct rights. Modifications: Use doPrivileged(...) when needed. Result: Fixes #8201.
|
@jprante PTAL as well |
normanmaurer
requested review from
carl-mastrangelo,
ejona86,
Scottmitch,
trustin and
bryce-anderson
ejona86
approved these changes
Aug 18, 2018
|
@normanmaurer handles out of scope? |
|
@johnou there is a lot other things to fix that also can use handles so I think I would do this as a follow up with a much bigger scope |
| } | ||
|
|
||
| private static void freeDirectBufferPrivileged(final ByteBuffer buffer) { | ||
| Exception error = AccessController.doPrivileged(new PrivilegedAction<Exception>() { |
There was a problem hiding this comment.
idle question: why not use PrivilegedExceptionAction ?
There was a problem hiding this comment.
I think there is not much advantage here.. We will need to unwrap then etc.
trustin
approved these changes
Aug 21, 2018
| } catch (InvocationTargetException e) { | ||
| return e; | ||
| } catch (IllegalAccessException e) { | ||
| return e; |
There was a problem hiding this comment.
Also honestly I think it will not make any difference. So maybe just keep it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… installed.
Motivation:
CleanerJava9 currently fails whever a SecurityManager is installed. We should make use of AccessController.doPrivileged(...) so the user can give it the correct rights.
Modifications:
Use doPrivileged(...) when needed.
Result:
Fixes #8201.