Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete attribute #8214

Closed
christ258 opened this issue Aug 22, 2018 · 1 comment
Closed

Obsolete attribute #8214

christ258 opened this issue Aug 22, 2018 · 1 comment

Comments

@christ258
Copy link

hi, I find this:

/**
* @deprecated Use {@link MaxMessagesRecvByteBufAllocator}
*/
@deprecated
public static final ChannelOption MAX_MESSAGES_PER_READ = valueOf("MAX_MESSAGES_PER_READ");

I used to use this ‘MAX_MESSAGES_PER_READ’, Now use this 'MaxMessagesRecvByteBufAllocator', how can I use this?
@normanmaurer
Copy link
Member

Use MaxMessagesRecvByteBufAllocator#maxMessagesPerRead

normanmaurer added a commit that referenced this issue Aug 24, 2018
@normanmaurer
Clarify deprecation docs a bit.
3c3cfa7 
Motivation:

It seems to sometimes confuse people what to do to replace setMaxMessagePerRead(...).

Modifications:

Add some more details to the javadocs about the correct replacement.

Result:

Related to #8214.
@normanmaurer normanmaurer mentioned this issue Aug 24, 2018
Merged
normanmaurer added a commit that referenced this issue Aug 25, 2018
@normanmaurer
Clarify deprecation docs a bit. (#8226)
1bd9e66 
Motivation:

It seems to sometimes confuse people what to do to replace setMaxMessagePerRead(...).

Modifications:

Add some more details to the javadocs about the correct replacement.

Result:

Related to #8214.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@normanmaurer @christ258