Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testsuit-shading does not have dependency on netty.util.internal but uses it. build fails #8489

Closed
Feri73 opened this issue Nov 10, 2018 · 2 comments
Closed

testsuit-shading does not have dependency on netty.util.internal but uses it. build fails #8489

Feri73 opened this issue Nov 10, 2018 · 2 comments
Assignees
@normanmaurer
Milestone
4.1.32.Final

Comments

@Feri73
Copy link
Contributor

Feri73 commented Nov 10, 2018 •
edited
Loading

Expected behavior

be able to build testsuit-shading !

Actual behavior

ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project netty-testsuite-shading: Compilation failure: Compilation failure:
[ERROR] netty\testsuite-shading\src\test\java\io\netty\testsuite\shading\ShadingIT.java:[18,29] error: package io.netty.util.internal does not exist
[ERROR] netty\testsuite-shading\src\test\java\io\netty\testsuite\shading\ShadingIT.java:[31,27] error: cannot find symbol
[ERROR] symbol:   variable PlatformDependent
[ERROR] location: class ShadingIT

Steps to reproduce

try to build test-suit using mvn install or using "rebuild project" in intellij

Netty version

4.1.32.Final-SNAPSHOT

JVM version

1.8

OS version

Windows 10
@normanmaurer
Copy link
Member

Ah yeah... that's be cause its windows. Let me fix this.

normanmaurer added a commit that referenced this issue Nov 10, 2018
@normanmaurer
Include correct dependencies for testsuite-shading on windows.
e59850b 
Motivation:

We missed to include a profile for windows which means that we did not have the correct dependencies setup.

Modifications:

- Add missing profile
- Add assumeFalse(...) to ensure we do only test the native transpot shading on non windows platforms.
- Explicit specify dependency on netty-common

Result:

Fixes #8489.
@normanmaurer normanmaurer mentioned this issue Nov 10, 2018
Merged
@normanmaurer
Copy link
Member

@Feri73 please check #8491

@normanmaurer normanmaurer self-assigned this Nov 10, 2018
@normanmaurer normanmaurer added this to the 4.1.32.Final milestone Nov 10, 2018
normanmaurer added a commit that referenced this issue Nov 11, 2018
@normanmaurer
Include correct dependencies for testsuite-shading on windows.
a978ef5 
Motivation:

We missed to include a profile for windows which means that we did not have the correct dependencies setup.

Modifications:

- Add missing profile
- Add assumeFalse(...) to ensure we do only test the native transpot shading on non windows platforms.
- Explicit specify dependency on netty-common

Result:

Fixes #8489.
normanmaurer added a commit that referenced this issue Nov 12, 2018
@normanmaurer
Include correct dependencies for testsuite-shading on windows. (#8491)
88e4817 
Motivation:

We missed to include a profile for windows which means that we did not have the correct dependencies setup.

Modifications:

- Add missing profile
- Add assumeFalse(...) to ensure we do only test the native transpot shading on non windows platforms.
- Explicit specify dependency on netty-common

Result:

Fixes #8489.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
None yet
Projects
None yet
Milestone
4.1.32.Final
Development

No branches or pull requests
2 participants
@normanmaurer @Feri73