Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket handlers to support handshake timeout #8841

Closed
kachayev opened this issue Feb 3, 2019 · 1 comment
Closed

Websocket handlers to support handshake timeout #8841

kachayev opened this issue Feb 3, 2019 · 1 comment
Milestone

Comments

@kachayev
Copy link
Contributor

@kachayev kachayev commented Feb 3, 2019

The same way SslHandler provides handshakeTimeoutMillis setting... On the application level, it makes sense to limit the time we need to move from HANDSHAKE_ISSUED to HANDSHAKE_COMPLETE states when upgrading to WebSockets. If there are no objections to introducing this functionality out of the box, I'll do a PR.

@normanmaurer

This comment has been minimized.

Copy link
Member

@normanmaurer normanmaurer commented Feb 4, 2019

@kachayev sounds like a good idea... :)

normanmaurer added a commit that referenced this issue May 22, 2019
Motivation:

Support handshake timeout option in websocket handlers. It makes sense to limit the time we need to move from `HANDSHAKE_ISSUED` to `HANDSHAKE_COMPLETE` states when upgrading to WebSockets

Modification:

- Add `handshakeTimeoutMillis` option in `WebSocketClientProtocolHandshakeHandler`  and `WebSocketServerProtocolHandshakeHandler`.
- Schedule a timeout task, the task will trigger user event `HANDSHAKE_TIMEOUT` if the handshake timed out.

Result:

Fixes issue #8841
@normanmaurer normanmaurer added this to the 4.1.37.Final milestone May 22, 2019
normanmaurer added a commit that referenced this issue May 22, 2019
Motivation:

Support handshake timeout option in websocket handlers. It makes sense to limit the time we need to move from `HANDSHAKE_ISSUED` to `HANDSHAKE_COMPLETE` states when upgrading to WebSockets

Modification:

- Add `handshakeTimeoutMillis` option in `WebSocketClientProtocolHandshakeHandler`  and `WebSocketServerProtocolHandshakeHandler`.
- Schedule a timeout task, the task will trigger user event `HANDSHAKE_TIMEOUT` if the handshake timed out.

Result:

Fixes issue #8841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.