Websocket handlers to support handshake timeout #8841
Milestone
Comments
|
@kachayev sounds like a good idea... :) |
normanmaurer
pushed a commit
that referenced
this issue
May 22, 2019
Motivation: Support handshake timeout option in websocket handlers. It makes sense to limit the time we need to move from `HANDSHAKE_ISSUED` to `HANDSHAKE_COMPLETE` states when upgrading to WebSockets Modification: - Add `handshakeTimeoutMillis` option in `WebSocketClientProtocolHandshakeHandler` and `WebSocketServerProtocolHandshakeHandler`. - Schedule a timeout task, the task will trigger user event `HANDSHAKE_TIMEOUT` if the handshake timed out. Result: Fixes issue #8841
normanmaurer
pushed a commit
that referenced
this issue
May 22, 2019
Motivation: Support handshake timeout option in websocket handlers. It makes sense to limit the time we need to move from `HANDSHAKE_ISSUED` to `HANDSHAKE_COMPLETE` states when upgrading to WebSockets Modification: - Add `handshakeTimeoutMillis` option in `WebSocketClientProtocolHandshakeHandler` and `WebSocketServerProtocolHandshakeHandler`. - Schedule a timeout task, the task will trigger user event `HANDSHAKE_TIMEOUT` if the handshake timed out. Result: Fixes issue #8841
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The same way
SslHandlerprovideshandshakeTimeoutMillissetting... On the application level, it makes sense to limit the time we need to move fromHANDSHAKE_ISSUEDtoHANDSHAKE_COMPLETEstates when upgrading to WebSockets. If there are no objections to introducing this functionality out of the box, I'll do a PR.The text was updated successfully, but these errors were encountered: