Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more information with the ClosedChannelException when fail operation with it #8862

Closed
normanmaurer opened this issue Feb 12, 2019 · 1 comment · Fixed by #8863
Closed

Provide more information with the ClosedChannelException when fail operation with it #8862

normanmaurer opened this issue Feb 12, 2019 · 1 comment · Fixed by #8863
Labels
improvement
Milestone
4.1.34.Final

Comments

@normanmaurer
Copy link
Member

If we close a Channel because of a failed write we should store the "original" exception in the ClosedChannelException that will be used to fail further operations to make it easier to understand why the Channel was closed before.

This came up yesterday in a discussion with @Scottmitch @ejona86 @carl-mastrangelo .
@normanmaurer normanmaurer added this to the 4.1.34.Final milestone Feb 12, 2019
@ejona86
Copy link
Member

ejona86 commented Feb 12, 2019

+1

@normanmaurer normanmaurer mentioned this issue Feb 12, 2019
Merged
normanmaurer added a commit that referenced this issue Feb 13, 2019
@normanmaurer
Include the original Exception that caused the Channel to be closed i…
e827971 
…n the ClosedChannelException

Motivation:

To make it easier to understand why a Channel was closed previously and so why the operation failed with a ClosedChannelException we should include the original Exception.

Modifications:

- Store the original exception that lead to the closed Channel and include it in the ClosedChannelException that is used to fail the operation.
- Add unit test

Result:

Fixes #8862.
normanmaurer added a commit that referenced this issue Feb 15, 2019
@normanmaurer
Include the original Exception that caused the Channel to be closed i…
f176384 
…n the ClosedChannelException (#8863)

Motivation:

To make it easier to understand why a Channel was closed previously and so why the operation failed with a ClosedChannelException we should include the original Exception.

Modifications:

- Store the original exception that lead to the closed Channel and include it in the ClosedChannelException that is used to fail the operation.
- Add unit test

Result:

Fixes #8862.
normanmaurer added a commit that referenced this issue Feb 15, 2019
@normanmaurer
Include the original Exception that caused the Channel to be closed i…
68d8bd9 
…n the ClosedChannelException (#8863)

Motivation:

To make it easier to understand why a Channel was closed previously and so why the operation failed with a ClosedChannelException we should include the original Exception.

Modifications:

- Store the original exception that lead to the closed Channel and include it in the ClosedChannelException that is used to fail the operation.
- Add unit test

Result:

Fixes #8862.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
4.1.34.Final
Development

Successfully merging a pull request may close this issue.

Include the original Exception that caused the Channel to be closed i… netty/netty
2 participants
@normanmaurer @ejona86