Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The netty-all.jar is missing the native-image.properties files from sub-modules #9514

Closed
cstancu opened this issue Aug 27, 2019 · 3 comments · Fixed by #9518
Closed

The netty-all.jar is missing the native-image.properties files from sub-modules #9514

cstancu opened this issue Aug 27, 2019 · 3 comments · Fixed by #9518
Milestone
4.1.41.Final

Comments

@cstancu
Copy link
Contributor

cstancu commented Aug 27, 2019 •
edited

The GraalVM Native Image configuration files under META-INF are automatically included in the generated jar of the corresponding module, e.g., native-image.properties is included in the netty-codec-http.jar, but not in nety-all.jar. I looked around the Netty build system but couldn't figure it out. It looks like the sub-module jars include the files in the corresponding META-INF directories automatically.
cc: @pmlopes
@pmlopes
Copy link
Contributor

pmlopes commented Aug 27, 2019

I don't know the inner details of the netty-all build process. I guess it would be nice to have but I am at the same level as you here...

@normanmaurer
Copy link
Member

I will have a look.

normanmaurer added a commit that referenced this issue Aug 27, 2019
@normanmaurer
Include native-image properties in the netty-all jar
cb110cf 
Motivation:

We need to also include the native-image configuration files in the netty all jar to be able to use it with GraalVM native.

Modifications:

Add files in META-INF/native-image as well

Result:

Fixes #9514
@normanmaurer normanmaurer mentioned this issue Aug 27, 2019
Merged
@normanmaurer
Copy link
Member

Fixed by #9518... PTAL

@normanmaurer normanmaurer added this to the 4.1.40.Final milestone Aug 27, 2019
normanmaurer added a commit that referenced this issue Aug 28, 2019
@normanmaurer
Include native-image properties in the netty-all jar (#9518)
cfcf20a 
Motivation:

We need to also include the native-image configuration files in the netty all jar to be able to use it with GraalVM native.

Modifications:

Add files in META-INF/native-image as well

Result:

Fixes #9514
normanmaurer added a commit that referenced this issue Aug 28, 2019
@normanmaurer
Include native-image properties in the netty-all jar (#9518)
99fecde 
Motivation:

We need to also include the native-image configuration files in the netty all jar to be able to use it with GraalVM native.

Modifications:

Add files in META-INF/native-image as well

Result:

Fixes #9514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.41.Final
Development

Successfully merging a pull request may close this issue.

Include native-image properties in the netty-all jar netty/netty
3 participants
@normanmaurer @pmlopes @cstancu