Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OioSocketChannel and RxtxChannel block often unnecessary on reads #962

Closed
normanmaurer opened this issue Jan 21, 2013 · 1 comment
Closed

OioSocketChannel and RxtxChannel block often unnecessary on reads #962

normanmaurer opened this issue Jan 21, 2013 · 1 comment
Assignees
@normanmaurer
Labels
defect improvement
Milestone
4.0.0.Beta1

Comments

@normanmaurer
Copy link
Member

We currently use:

buffer.writeBytes(in, buffer.writableBytes());

we should better check what is avaible and if it is bigger then 0 use it if it not exceed buffer.writableBytes.
@ghost ghost assigned normanmaurer Jan 21, 2013
normanmaurer pushed a commit that referenced this issue Jan 21, 2013
[#962] Read data as soon as it is present in OIO and not wait till it…
082b5f0 
… match Buffer.writableBytes()

- Also add a new abstract class called StreamOioByteChannel which can be used by OIO channel implementation which are Stream based as a starting point.
@normanmaurer
Copy link
Member Author

Fixed..

This was referenced Jan 21, 2013
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
defect improvement
Projects
None yet
Milestone
4.0.0.Beta1
Development

No branches or pull requests
1 participant
@normanmaurer