SslHandler should fail handshake / close promise and notify pipeline … #10161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on removal Motivation: If the SslHandler is removed from the pipeline we also need to ensure we fail the handshake / close promise if it was not notified before as otherwise we may never do so. Modifications: - Correctly fail promise and notify pipeline if handshake was not done yet when the SslHandler is removed - Add unit test Result: Fix #10158
normanmaurer
force-pushed
the
fail_promise_on_removal
branch
from
febecc4
to
ccedbe5
Compare
NiteshKant
reviewed
Apr 2, 2020
NiteshKant
approved these changes
Apr 2, 2020
BenD10
approved these changes
Apr 3, 2020
normanmaurer
added a commit
that referenced
this pull request
Apr 3, 2020
…on removal (#10161) Motivation: If the SslHandler is removed from the pipeline we also need to ensure we fail the handshake / close promise if it was not notified before as otherwise we may never do so. Modifications: - Correctly fail promise and notify pipeline if handshake was not done yet when the SslHandler is removed - Add unit test Result: Fix #10158
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
…on removal (netty#10161) Motivation: If the SslHandler is removed from the pipeline we also need to ensure we fail the handshake / close promise if it was not notified before as otherwise we may never do so. Modifications: - Correctly fail promise and notify pipeline if handshake was not done yet when the SslHandler is removed - Add unit test Result: Fix netty#10158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on removal
Motivation:
If the SslHandler is removed from the pipeline we also need to ensure we fail the handshake / close promise if it was not notified before as otherwise we may never do so.
Modifications:
Result:
Fix #10158