Reuse the same allocator as used by the ByteBuf that is used during…
#10226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @fabienrenaud |
normanmaurer
force-pushed
the
multi_part_alloc
branch
from
db13040
to
dde1499
Compare
… multipart decoding Motivation: We should not use Unpooled to allocate buffers if possible to ensure we can make use of pooling etc. Modifications: - Only allocate a buffer if really needed - Use the ByteBufAllocator of the offered ByteBuf - Ensure we not use buffer.copy() but explicitly allocate a buffer and then copy into it to not hit the limit of maxCapacity() Result: Improve allocations
normanmaurer
force-pushed
the
multi_part_alloc
branch
from
dde1499
to
278b781
Compare
slandelle
approved these changes
Apr 29, 2020
|
@slandelle addressed.... PTAL again |
normanmaurer
added a commit
that referenced
this pull request
Apr 29, 2020
#10226) Motivation: We should not use Unpooled to allocate buffers if possible to ensure we can make use of pooling etc. Modifications: - Only allocate a buffer if really needed - Use the ByteBufAllocator of the offered ByteBuf - Ensure we not use buffer.copy() but explicitly allocate a buffer and then copy into it to not hit the limit of maxCapacity() Result: Improve allocations
Kvicii
pushed a commit
to Kvicii/netty
that referenced
this pull request
May 4, 2020
* '4.1' of github.com:netty/netty: (24 commits) Rename testmethods to make these more clear (netty#10231) Specify algorithm for key pair in self signed certificate to generate EC or RSA based certificate. (netty#10223) Reuse the same allocator as used by the `ByteBuf` that is used during… (netty#10226) Remove some debugging cruft (netty#10229) Fix memory leak in HttpPostMultipartRequestDecoder (netty#10227) Don't log with warn level in the DnsNameResolver in most cases (netty#10225) Detect CNAME loops in the CNAME cache while trying to resolve (netty#10221) Update to latest Conscrypt release and add workarounds for bugs (netty#10211) HttpPostRequestDecoder: retain instead of copy when first buf is last (netty#10209) Move up the size check in AbstractDiskHttpData.setContent. (netty#10222) Dns resolver: honor resolv.conf timeout, rotate and attempts options (netty#10207) Add check for DefaultFileRegion to calculate size of msg in AbstractTrafficShapingHandler (netty#10215) Remove unused import in JsonObjectDecoder.java (netty#10213) Fix a potential fd leak in AbstractDiskHttpData.delete (netty#10212) Update testsuite / pom.xml to be able to build with Java15 (netty#10210) Add fastpath implementation for Unpooled.copiedBuffer(CharSequence, Charset) when UTF-8 or US-ASCII is used (netty#10206) Add epoll aarch64 maven config and Dockerfile (netty#9804) HTTP2: Guard against multiple ctx.close(...) calls with the same ChannelPromise (netty#10201) [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release netty-4.1.49.Final ...
ihanyong
pushed a commit
to ihanyong/netty
that referenced
this pull request
Jul 31, 2020
netty#10226) Motivation: We should not use Unpooled to allocate buffers if possible to ensure we can make use of pooling etc. Modifications: - Only allocate a buffer if really needed - Use the ByteBufAllocator of the offered ByteBuf - Ensure we not use buffer.copy() but explicitly allocate a buffer and then copy into it to not hit the limit of maxCapacity() Result: Improve allocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… multipart decoding
Motivation:
We should not use Unpooled to allocate buffers if possible to ensure we can make use of pooling etc.
Modifications:
Result:
Improve allocations