Add HttpScheme Support in HttpToHttp2ConnectionHandler #10641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@netty-bot test this please |
|
@chrisvest https://ci.netty.io/ is returning 502 Bad Gateway response. Looks like the CI server is down. @normanmaurer Do you have any updates on the CI server? |
|
Ready to merge. :D |
normanmaurer
requested changes
Oct 26, 2020
codec-http2/src/main/java/io/netty/handler/codec/http2/HttpToHttp2ConnectionHandler.java
Outdated
Show resolved
Hide resolved
|
@netty-bot test this please |
normanmaurer
requested changes
Nov 4, 2020
...-http2/src/main/java/io/netty/handler/codec/http2/AbstractHttp2ConnectionHandlerBuilder.java
Outdated
Show resolved
Hide resolved
|
@netty-bot test this please |
1 similar comment
|
@netty-bot test this please |
|
Looks like some problem with CI for Java 11. |
normanmaurer
pushed a commit
that referenced
this pull request
Nov 5, 2020
Motivation: We should have a method to add `HttpScheme` if `HttpRequest` does not contain `x-http2-scheme` then we should use add it if `HttpToHttp2ConnectionHandler` is build using specified `HttpScheme`. Modification: Added `HttpScheme` in `HttpToHttp2ConnectionHandlerBuilder`. Result: Automatically add `HttpScheme` if missing in `HttpRequest`.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: We should have a method to add `HttpScheme` if `HttpRequest` does not contain `x-http2-scheme` then we should use add it if `HttpToHttp2ConnectionHandler` is build using specified `HttpScheme`. Modification: Added `HttpScheme` in `HttpToHttp2ConnectionHandlerBuilder`. Result: Automatically add `HttpScheme` if missing in `HttpRequest`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should have a method to add
HttpSchemeifHttpResponsedoes not containx-http2-schemethen we should use add it ifHttpToHttp2ConnectionHandleris build using specifiedHttpScheme.Modification:
Added
HttpSchemeinHttpToHttp2ConnectionHandlerBuilder.Result:
Automatically add
HttpSchemeif missing inHttpResponse.