Ensure we also build dependent modules for deployments #10936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We need to ensure we also build the modules we depend on as otherwise we may not be able to resolve the dependencies correctly Modifications: - Add -am when calling maven Result: Deployment works all the time
ZzxyNn
pushed a commit
to ZzxyNn/netty
that referenced
this pull request
Jan 29, 2021
Motivation: We need to ensure we also build the modules we depend on as otherwise we may not be able to resolve the dependencies correctly Modifications: - Add -am when calling maven Result: Deployment works all the time
normanmaurer
added a commit
that referenced
this pull request
Mar 15, 2021
Motivation: We need to ensure we also build the modules we depend on as otherwise we may not be able to resolve the dependencies correctly Modifications: - Add -am when calling maven Result: Deployment works all the time
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: We need to ensure we also build the modules we depend on as otherwise we may not be able to resolve the dependencies correctly Modifications: - Add -am when calling maven Result: Deployment works all the time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to ensure we also build the modules we depend on as otherwise we may not be able to resolve the dependencies correctly
Modifications:
Result:
Deployment works all the time