Add a profile for debugging tests that run from Maven #11011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In some cases, Intellij struggles to recreate the build and test environment/configuration that Maven produces, and this can lead to tests behaving differently when run from Intellij compared to when they run from Maven. This in turn can make debugging those tests harder. Modification: Add a profile to the Maven build, that will add the necessary command line arguments for attaching the Intellij debugger to tests that are executed from Maven. Result: It is now possible to debug the tests that Maven is running, from Intellij, by enabling the -PijDebug Maven profile.
normanmaurer
approved these changes
Feb 9, 2021
chrisvest
added a commit
that referenced
this pull request
Feb 10, 2021
* Revert "Add a profile for debugging tests that run from Maven (#11011)" This reverts commit 83895f0 The same functionality is already natively available in surefire, by adding the `-Dmaven.surefire.debug` flag to Maven. * Update surefire/failsafe version These new versions copes better when our tests prints to STDOUT, and disturbs the progress processing that these plugins do.
chrisvest
added a commit
that referenced
this pull request
Feb 10, 2021
* Revert "Add a profile for debugging tests that run from Maven (#11011)" This reverts commit 83895f0 The same functionality is already natively available in surefire, by adding the `-Dmaven.surefire.debug` flag to Maven. * Update surefire/failsafe version These new versions copes better when our tests prints to STDOUT, and disturbs the progress processing that these plugins do.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: In some cases, Intellij struggles to recreate the build and test environment/configuration that Maven produces, and this can lead to tests behaving differently when run from Intellij compared to when they run from Maven. This in turn can make debugging those tests harder. Modification: Add a profile to the Maven build, that will add the necessary command line arguments for attaching the Intellij debugger to tests that are executed from Maven. Result: It is now possible to debug the tests that Maven is running, from Intellij, by enabling the -PijDebug Maven profile.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
* Revert "Add a profile for debugging tests that run from Maven (netty#11011)" This reverts commit 83895f0 The same functionality is already natively available in surefire, by adding the `-Dmaven.surefire.debug` flag to Maven. * Update surefire/failsafe version These new versions copes better when our tests prints to STDOUT, and disturbs the progress processing that these plugins do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In some cases, Intellij struggles to recreate the build and test
environment/configuration that Maven produces, and this can lead to tests
behaving differently when run from Intellij compared to when they run from
Maven.
This in turn can make debugging those tests harder.
Modification:
Add a profile to the Maven build, that will add the necessary command line
arguments for attaching the Intellij debugger to tests that are executed from
Maven.
Result:
It is now possible to debug the tests that Maven is running, from Intellij,
by enabling the -PijDebug Maven profile.