Make CompositeByteBuf throw IllegalStateException when components are missing #11100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… missing Motivation: Components in a composite buffer can "go missing" if the composite is a slice of another composite and the parent has changed its layout. Modification: Where we would previously have thrown a NullPointerException, we now have a null-check for the component, and we instead throw an IllegalStateException with a more descriptive message. Result: It's now a bit easier to understand what is going on in these situations. Fixes netty#10908
normanmaurer
approved these changes
Mar 18, 2021
chrisvest
added a commit
that referenced
this pull request
Mar 18, 2021
… missing (#11100) Motivation: Components in a composite buffer can "go missing" if the composite is a slice of another composite and the parent has changed its layout. Modification: Where we would previously have thrown a NullPointerException, we now have a null-check for the component, and we instead throw an IllegalStateException with a more descriptive message. Result: It's now a bit easier to understand what is going on in these situations. Fixes #10908
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
… missing (netty#11100) Motivation: Components in a composite buffer can "go missing" if the composite is a slice of another composite and the parent has changed its layout. Modification: Where we would previously have thrown a NullPointerException, we now have a null-check for the component, and we instead throw an IllegalStateException with a more descriptive message. Result: It's now a bit easier to understand what is going on in these situations. Fixes netty#10908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Components in a composite buffer can "go missing" if the composite is a slice of another composite and the parent has changed its layout.
Modification:
Where we would previously have thrown a NullPointerException, we now have a null-check for the component, and we instead throw an IllegalStateException with a more descriptive message.
Result:
It's now a bit easier to understand what is going on in these situations.
Fixes #10908