Remove unnecessary checks in WebSocket08FrameDecoder (IDE highlighted) #11113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doom369 thanks |
normanmaurer
pushed a commit
that referenced
this pull request
Mar 29, 2021
Motivation: There are some redundant checks and so these can be removed Modifications: - First check frameOpcode != OPCODE_PING is removed because the code executed int the branch where frameOpcode <= 7, while OPCODE_PING is 9. - Second check frameOpcode != OPCODE_PING is removed because its checked before. Result: Code cleanup
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: There are some redundant checks and so these can be removed Modifications: - First check frameOpcode != OPCODE_PING is removed because the code executed int the branch where frameOpcode <= 7, while OPCODE_PING is 9. - Second check frameOpcode != OPCODE_PING is removed because its checked before. Result: Code cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First check
frameOpcode != OPCODE_PINGis removed because the code executed int the branch whereframeOpcode <= 7, whileOPCODE_PINGis 9.Second check
frameOpcode != OPCODE_PINGis removed because the above code has: