[Clean] Remove useless code #11154
Merged
[Clean] Remove useless code #11154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove useless code 2. Change io.netty.handler.codec.http.HttpContentEncoder.State to volatile to ensure memory visibility
normanmaurer
requested changes
Apr 15, 2021
codec-http/src/main/java/io/netty/handler/codec/http/HttpContentEncoder.java
Outdated
Show resolved
Hide resolved
chrisvest
approved these changes
Apr 16, 2021
normanmaurer
pushed a commit
that referenced
this pull request
Apr 19, 2021
Motivation: There is an unused field Modifications: Remove useless code Result: Code cleanup Co-authored-by: xingrufei <xingrufei@sogou-inc.com>
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: There is an unused field Modifications: Remove useless code Result: Code cleanup Co-authored-by: xingrufei <xingrufei@sogou-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Clean code, including:
Please review this pr, thanks
If there is no issue then describe the changes introduced by this PR.