SslHandler consolidate state to save memory #11160
Conversation
Motivation: SslHandler has many independent boolean member variables. They can be collapsed into a single variable to save memory. Modifications: - SslHandler boolean state consolidated into a single short variable. Result: Savings of 8 bytes per SslHandler (which is per connection) observed on OpenJDK.
|
I need to add more state in #11156 which was the motivation for this PR. |
Motivation: SslHandler has many independent boolean member variables. They can be collapsed into a single variable to save memory. Modifications: - SslHandler boolean state consolidated into a single short variable. Result: Savings of 8 bytes per SslHandler (which is per connection) observed on OpenJDK.
|
master (3049eac) |
| outboundBuffer.totalPendingWriteBytes() > 0); | ||
| if (fastOpen && ((outboundBuffer = channel.unsafe().outboundBuffer()) == null || | ||
| outboundBuffer.totalPendingWriteBytes() > 0)) { | ||
| setState(STATE_NEEDS_FLUSH); |
There was a problem hiding this comment.
(Tracking down some Netty-related issue led me to this PR, and led me to do a close reading. I noticed this and didn't want it to get lost in case it is valuable. It is also possible I've misread something.)
On this line, the prior version has:
needsFlush |= ...
…so shouldn't there be a corresponding clearState(STATE_NEEDS_FLUSH) if the elaborate condition does not hold?
Again this is just from a flyby code read so I may have missed something deeper.
There was a problem hiding this comment.
That state is cleared when the flush happens. The effect of |= is to assign to the LHS the bitwise-OR of LHS and RHS. This PR does not change that behaviour. It just consolidates many fields into a single bit-field.
Motivation: SslHandler has many independent boolean member variables. They can be collapsed into a single variable to save memory. Modifications: - SslHandler boolean state consolidated into a single short variable. Result: Savings of 8 bytes per SslHandler (which is per connection) observed on OpenJDK.
Motivation:
SslHandler has many independent boolean member variables. They can be
collapsed into a single variable to save memory.
Modifications:
Result:
Savings of 8 bytes per SslHandler (which is per connection) observed on
OpenJDK.