Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DnsNameResolver resolves the host(computer) name on Windows #11167

Merged
merged 2 commits into from Apr 20, 2021
Merged

Ensure DnsNameResolver resolves the host(computer) name on Windows #11167

merged 2 commits into from Apr 20, 2021

Commits on Apr 19, 2021

  1. Ensure DnsNameResolver resolves the host(computer) name on Windows

    Motivation:
    
    On Windows DnsNameResolver is not able to resolve the host(computer) name as it is not in the hosts file and the DNS server is also not able to resolve it.
    The exception below is the result of the resolution:
    Caused by: java.net.UnknownHostException: failed to resolve 'host(computer)-name' after 2 queries
    	at io.netty.resolver.dns.DnsResolveContext.finishResolve(DnsResolveContext.java:1013)
    	at io.netty.resolver.dns.DnsResolveContext.tryToFinishResolve(DnsResolveContext.java:966)
    	at io.netty.resolver.dns.DnsResolveContext.query(DnsResolveContext.java:414)
    	at io.netty.resolver.dns.DnsResolveContext.tryToFinishResolve(DnsResolveContext.java:938)
    	at io.netty.resolver.dns.DnsResolveContext.access$700(DnsResolveContext.java:63)
    	at io.netty.resolver.dns.DnsResolveContext$2.operationComplete(DnsResolveContext.java:467)
    
    Modifications:
    
    On Windows DnsNameResolver maps host(computer) name to LOCALHOST
    
    Result:
    
    DnsNameResolver is able to resolve the host(computer) name on Windows
    
    Fixes #11142
    violetagg committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    d26815e View commit details
    Browse the repository at this point in the history
  2. Address feedback

    violetagg committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    41a7e9d View commit details
    Browse the repository at this point in the history