Utilize i.n.u.internal.ObjectUtil Preconditions (commons) (#11170) #11172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@normanmaurer Thanks for your offer to check this. The build failed but I cannot see the relation between change and error. Looks like an infrastructure topic? Could you please check and advise? |
normanmaurer
requested changes
Apr 20, 2021
boris-unckel
force-pushed
the
11170_preconditions_objectutils_common
branch
from
19dce23
to
79bc10a
Compare
normanmaurer
approved these changes
Apr 20, 2021
chrisvest
approved these changes
Apr 21, 2021
rkapsi
reviewed
Apr 21, 2021
rkapsi
reviewed
Apr 21, 2021
boris-unckel
force-pushed
the
11170_preconditions_objectutils_common
branch
from
79bc10a
to
9ca763e
Compare
amizurov
reviewed
Apr 21, 2021
boris-unckel
force-pushed
the
11170_preconditions_objectutils_common
branch
from
9ca763e
to
ed9a4ed
Compare
…etty#11170) Motivation: NullChecks resulting in a NullPointerException or IllegalArgumentException, numeric ranges (>0, >=0) checks, not empty strings/arrays checks must never be anonymous but with the parameter or variable name which is checked. They must be specific and should not be done with an "OR-Logic" (if a == null || b == null) throw new NullPointerEx. Modifications: * Add some checks to ObjectUtil not present today but utilized in the code. * Add unit test for ObjectUtil * Update commmons internal usage with ObjectUtil Result: All checks needed are present, subsequent changes of usage of ObjectUtil are possible. Fixes for netty#11170 One PR for each subproject to ease review.
boris-unckel
force-pushed
the
11170_preconditions_objectutils_common
branch
from
ed9a4ed
to
b004f5c
Compare
|
@rkapsi PTAL again |
|
LGTM |
rkapsi
approved these changes
Apr 22, 2021
|
@boris-unckel thanks a lot! |
normanmaurer
pushed a commit
that referenced
this pull request
Apr 22, 2021
…11170) (#11172) Motivation: NullChecks resulting in a NullPointerException or IllegalArgumentException, numeric ranges (>0, >=0) checks, not empty strings/arrays checks must never be anonymous but with the parameter or variable name which is checked. They must be specific and should not be done with an "OR-Logic" (if a == null || b == null) throw new NullPointerEx. Modifications: * Add some checks to ObjectUtil not present today but utilized in the code. * Add unit test for ObjectUtil * Update commmons internal usage with ObjectUtil Result: All checks needed are present, subsequent changes of usage of ObjectUtil are possible. Fixes for #11170
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Apr 28, 2021
The exception message is changed with netty/netty#11172
violetagg
added a commit
to reactor/reactor-netty
that referenced
this pull request
Apr 28, 2021
The exception message is changed with netty/netty#11172
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…etty#11170) (netty#11172) Motivation: NullChecks resulting in a NullPointerException or IllegalArgumentException, numeric ranges (>0, >=0) checks, not empty strings/arrays checks must never be anonymous but with the parameter or variable name which is checked. They must be specific and should not be done with an "OR-Logic" (if a == null || b == null) throw new NullPointerEx. Modifications: * Add some checks to ObjectUtil not present today but utilized in the code. * Add unit test for ObjectUtil * Update commmons internal usage with ObjectUtil Result: All checks needed are present, subsequent changes of usage of ObjectUtil are possible. Fixes for netty#11170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
NullChecks resulting in a NullPointerException or IllegalArgumentException, numeric ranges (>0, >=0) checks, not empty strings/arrays checks must never be anonymous but with the parameter or variable name which is checked. They must be specific and should not be done with an "OR-Logic" (if a == null || b == null) throw new NullPointerEx.
Modifications:
Result:
All checks needed are present, subsequent changes of usage of ObjectUtil are possible.
Fixes for #11170
One PR for each subproject to ease review.