Decrease visibility of Http2FrameCodecBuilder default ctor to protected
#11220
Conversation
idelpivnitskiy
changed the title
Http2FrameCodecBuilder default ctor to protected
…ected` Motivation: `Http2FrameCodecBuilder` defines static factory methods `forClient()` and `forServer()` that should be used to create a new instance. The default ctor is useful only when users need to override behavior of the existing builder. Those users should define another way to create an instance. Modifications: - Decrease visibility of `Http2FrameCodecBuilder` default ctor from `public` to `protected`; - Add javadoc to clarity responsibilities; Result: Users of `Http2FrameCodecBuilder` are not confused why `new Http2FrameCodecBuilder().build()` works for the server-side, but does not work for the client-side.
idelpivnitskiy
force-pushed
the
Http2FrameCodecBuilder
branch
from
22b6f60
to
90a7c14
Compare
@idelpivnitskiy not sure I get this, can you provide a sample code of what does not work? The intent of the no-arg constructor here is to create a "clean instance" where no state is implicitly set as is the case with the |
|
For this type of the builder, the |
|
The |
…ected` (#11220) Motivation: `Http2FrameCodecBuilder` defines static factory methods `forClient()` and `forServer()` that should be used to create a new instance. The default ctor is useful only when users need to override behavior of the existing builder. Those users should define another way to create an instance. Modifications: - Decrease visibility of `Http2FrameCodecBuilder` default ctor from `public` to `protected`; - Add javadoc to clarity responsibilities; Result: Users of `Http2FrameCodecBuilder` are not confused why `new Http2FrameCodecBuilder().build()` works for the server-side, but does not work for the client-side.
…ected` (netty#11220) Motivation: `Http2FrameCodecBuilder` defines static factory methods `forClient()` and `forServer()` that should be used to create a new instance. The default ctor is useful only when users need to override behavior of the existing builder. Those users should define another way to create an instance. Modifications: - Decrease visibility of `Http2FrameCodecBuilder` default ctor from `public` to `protected`; - Add javadoc to clarity responsibilities; Result: Users of `Http2FrameCodecBuilder` are not confused why `new Http2FrameCodecBuilder().build()` works for the server-side, but does not work for the client-side.
Motivation:
Http2FrameCodecBuilderdefines static factory methodsforClient()and
forServer()that should be used to create a new instance.The default ctor is useful only when users need to override behavior
of the existing builder. Those users should define another way to create
an instance.
Modifications:
Http2FrameCodecBuilderdefault ctor frompublictoprotected;Result:
Users of
Http2FrameCodecBuilderare not confused whynew Http2FrameCodecBuilder().build()works for the server-side, butdoes not work for the client-side.
Follow-up for #11195.