Use profile for overriding properties when building on the CI #11232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: 0f25213 introduced some properties that were used to make builds more stable on the ci. All of these properties were duplicated everywhere, this made it hard to maintain Modifications: - Add profile which sets the properties. - Just use the profile when build on the ci Result: Easier to maintain custom properties for the ci build
chrisvest
approved these changes
May 7, 2021
normanmaurer
added a commit
that referenced
this pull request
May 7, 2021
Motivation: 0f25213 introduced some properties that were used to make builds more stable on the ci. All of these properties were duplicated everywhere, this made it hard to maintain Modifications: - Add profile which sets the properties. - Just use the profile when build on the ci Result: Easier to maintain custom properties for the ci build
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…11232) Motivation: 0f25213 introduced some properties that were used to make builds more stable on the ci. All of these properties were duplicated everywhere, this made it hard to maintain Modifications: - Add profile which sets the properties. - Just use the profile when build on the ci Result: Easier to maintain custom properties for the ci build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
0f25213 introduced some properties that were used to make builds more stable on the ci. All of these properties were duplicated everywhere, this made it hard to maintain
Modifications:
Result:
Easier to maintain custom properties for the ci build