Log if the user tries to explicit set TLSv1.3 ciphers and using Borin… #11392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gSSL Motivation: At the moment BoringSSL doesnt support explicit set the TLSv1.3 ciphers that should be used. If TLSv1.3 should be used it just enables all ciphers. We should better log if the user tries to explicit set a specific ciphers and using BoringSSL to inform the user that what is tried doesnt really work. Modifications: Log if the user tries to not use all TLSv1.3 ciphers and use BoringSSL Result: Easier for the user to understand why always all TLSv1.3 ciphers are enabled when using BoringSSL
normanmaurer
force-pushed
the
boringssl_tlsv13_log
branch
from
e9dc889
to
06de483
Compare
Co-authored-by: Trustin Lee <trustin@gmail.com>
normanmaurer
added a commit
that referenced
this pull request
Jun 21, 2021
…gSSL (#11392) Motivation: At the moment BoringSSL doesnt support explicit set the TLSv1.3 ciphers that should be used. If TLSv1.3 should be used it just enables all ciphers. We should better log if the user tries to explicit set a specific ciphers and using BoringSSL to inform the user that what is tried doesnt really work. Modifications: Log if the user tries to not use all TLSv1.3 ciphers and use BoringSSL Result: Easier for the user to understand why always all TLSv1.3 ciphers are enabled when using BoringSSL Co-authored-by: Trustin Lee <trustin@gmail.com>
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…gSSL (netty#11392) Motivation: At the moment BoringSSL doesnt support explicit set the TLSv1.3 ciphers that should be used. If TLSv1.3 should be used it just enables all ciphers. We should better log if the user tries to explicit set a specific ciphers and using BoringSSL to inform the user that what is tried doesnt really work. Modifications: Log if the user tries to not use all TLSv1.3 ciphers and use BoringSSL Result: Easier for the user to understand why always all TLSv1.3 ciphers are enabled when using BoringSSL Co-authored-by: Trustin Lee <trustin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…gSSL
Motivation:
At the moment BoringSSL doesnt support explicit set the TLSv1.3 ciphers that should be used. If TLSv1.3 should be used it just enables all ciphers. We should better log if the user tries to explicit set a specific ciphers and using BoringSSL to inform the user that what is tried doesnt really work.
Modifications:
Log if the user tries to not use all TLSv1.3 ciphers and use BoringSSL
Result:
Easier for the user to understand why always all TLSv1.3 ciphers are enabled when using BoringSSL