Fix IndexOutOfBoundsException caused by consuming the buffer multiple… #11592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
query_decoder_fix
branch
from
e74abdc
to
3122991
Compare
chrisvest
approved these changes
Aug 18, 2021
|
Thanks for the quick fix! 🙇♂️❤️ |
|
@normanmaurer thank you for the fix! Do you feel it's worth cutting a release for? We found ourselves blocked as some of our systems using DNS codec. |
|
Release is planed for next week @vkostyukov |
|
Thanks, Norman! That's great to hear! |
|
Hi @normanmaurer, any updates on a new release which includes this fix? Thanks! |
|
Yep … tomorrow
… Am 07.09.2021 um 19:49 schrieb Ruben Oanta ***@***.***>:
Hi @normanmaurer, any updates on a new release which includes this fix?
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
… times in DatagramDnsQueryDecoder (netty#11592) Motivation: ccef8fe introduced some changes to share code but did introduce a regression when decoding queries. Modifications: - Correctly only decode one time. - Adjust unit test Result: Fixes netty#11591
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
… times in DatagramDnsQueryDecoder (netty#11592) Motivation: ccef8fe introduced some changes to share code but did introduce a regression when decoding queries. Modifications: - Correctly only decode one time. - Adjust unit test Result: Fixes netty#11591
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
… times in DatagramDnsQueryDecoder (netty#11592) Motivation: ccef8fe introduced some changes to share code but did introduce a regression when decoding queries. Modifications: - Correctly only decode one time. - Adjust unit test Result: Fixes netty#11591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… times in DatagramDnsQueryDecoder
Motivation:
ccef8fe introduced some changes to share code but did introduce a regression when decoding queries.
Modifications:
Result:
Fixes #11591