Add unit test that verifies we not fail hostname verification if a ma… #11803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching SNI name was used Motivation: We didn't have a unit test that verifies that the SNI hostname is respected when hostname verification is performed Modifications: Add unit test Result: Ensure we not regress
normanmaurer
added a commit
that referenced
this pull request
Oct 28, 2021
…tching SNI name was used (#11803) Motivation: We didn't have a unit test that verifies that the SNI hostname is respected when hostname verification is performed Modifications: Add unit test Result: Ensure we not regress
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
…tching SNI name was used (netty#11803) Motivation: We didn't have a unit test that verifies that the SNI hostname is respected when hostname verification is performed Modifications: Add unit test Result: Ensure we not regress
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
…tching SNI name was used (netty#11803) Motivation: We didn't have a unit test that verifies that the SNI hostname is respected when hostname verification is performed Modifications: Add unit test Result: Ensure we not regress
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…tching SNI name was used (netty#11803) Motivation: We didn't have a unit test that verifies that the SNI hostname is respected when hostname verification is performed Modifications: Add unit test Result: Ensure we not regress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tching SNI name was used
Motivation:
We didn't have a unit test that verifies that the SNI hostname is respected when hostname verification is performed
Modifications:
Add unit test
Result:
Ensure we not regress