Specify the platform version and deployment target on macos #11906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We should specify the platform version and deployment target when on macos as otherwise we might change requirements of minimal macOS version without notice it. Modifications: - Add -platform_version to the linker args - Always specify MACOSX_DEPLOYMENT_TARGET target Result: Be able to use native macOS libs again on older macOS releases
chrisvest
approved these changes
Dec 10, 2021
normanmaurer
added a commit
that referenced
this pull request
Dec 10, 2021
Motivation: We should specify the platform version and deployment target when on macos as otherwise we might change requirements of minimal macOS version without notice it. Modifications: - Add -platform_version to the linker args - Always specify MACOSX_DEPLOYMENT_TARGET target Result: Be able to use native macOS libs again on older macOS releases
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
) Motivation: We should specify the platform version and deployment target when on macos as otherwise we might change requirements of minimal macOS version without notice it. Modifications: - Add -platform_version to the linker args - Always specify MACOSX_DEPLOYMENT_TARGET target Result: Be able to use native macOS libs again on older macOS releases
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
) Motivation: We should specify the platform version and deployment target when on macos as otherwise we might change requirements of minimal macOS version without notice it. Modifications: - Add -platform_version to the linker args - Always specify MACOSX_DEPLOYMENT_TARGET target Result: Be able to use native macOS libs again on older macOS releases
10brothers
pushed a commit
to 10brothers/netty
that referenced
this pull request
Jan 20, 2022
) Motivation: We should specify the platform version and deployment target when on macos as otherwise we might change requirements of minimal macOS version without notice it. Modifications: - Add -platform_version to the linker args - Always specify MACOSX_DEPLOYMENT_TARGET target Result: Be able to use native macOS libs again on older macOS releases
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
) Motivation: We should specify the platform version and deployment target when on macos as otherwise we might change requirements of minimal macOS version without notice it. Modifications: - Add -platform_version to the linker args - Always specify MACOSX_DEPLOYMENT_TARGET target Result: Be able to use native macOS libs again on older macOS releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should specify the platform version and deployment target when on macos as otherwise we might change requirements of minimal macOS version without notice it.
Modifications:
Result:
Be able to use native macOS libs again on older macOS releases