Don't strip scopeId when resolving ipv6 address #12019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Due a bug we did strip the scopeId of the ipv6 address string when using the DnsNameResolver. This could later then result to things like "No Route to host" exceptions. Modifications: - Add new method to NetUtil which will create the InetAddress for an string that contains an ip while still preserve the scopeId. - Use this new method - Add unit tests. Result: Fixes #11563
|
FYI @vietj as this came up as a vertx issue first. |
chrisvest
approved these changes
Jan 19, 2022
normanmaurer
added a commit
that referenced
this pull request
Jan 19, 2022
Motivation: Due a bug we did strip the scopeId of the ipv6 address string when using the DnsNameResolver. This could later then result to things like "No Route to host" exceptions. Modifications: - Add new method to NetUtil which will create the InetAddress for an string that contains an ip while still preserve the scopeId. - Use this new method - Add unit tests. Result: Fixes #11563
10brothers
pushed a commit
to 10brothers/netty
that referenced
this pull request
Jan 20, 2022
Motivation: Due a bug we did strip the scopeId of the ipv6 address string when using the DnsNameResolver. This could later then result to things like "No Route to host" exceptions. Modifications: - Add new method to NetUtil which will create the InetAddress for an string that contains an ip while still preserve the scopeId. - Use this new method - Add unit tests. Result: Fixes netty#11563
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: Due a bug we did strip the scopeId of the ipv6 address string when using the DnsNameResolver. This could later then result to things like "No Route to host" exceptions. Modifications: - Add new method to NetUtil which will create the InetAddress for an string that contains an ip while still preserve the scopeId. - Use this new method - Add unit tests. Result: Fixes netty#11563
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Due a bug we did strip the scopeId of the ipv6 address string when using the DnsNameResolver. This could later then result to things like "No Route to host" exceptions.
Modifications:
Result:
Fixes #11563