Replace ctx.channel().writeAndFlush with ctx.writeAndFlush in WebSockets handlers #12540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I really doubt that this is going to make any improvement in performance. |
|
@hyperxpro imho this is less about performance but more about correctness. |
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…ets handlers (netty#12540) Motivation: There is no actual need to call `ctx.channel().writeAndFlush` instead of `ctx.writeAndFlush`. Using the context is also more correct as it start at the right place in the pipeline. Modification: Use the context and not the channel Result: More correct code
franz1981
pushed a commit
to franz1981/netty
that referenced
this pull request
Aug 22, 2022
…ets handlers (netty#12540) Motivation: There is no actual need to call `ctx.channel().writeAndFlush` instead of `ctx.writeAndFlush`. Using the context is also more correct as it start at the right place in the pipeline. Modification: Use the context and not the channel Result: More correct code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
There is no actual need to call
ctx.channel().writeAndFlushinstead ofctx.writeAndFlush. Should be shorter execution path as well.