Offload multicast operations to the EventLoop if not called from with… #12584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found this while working on #12583 |
…in an EventLoop thread Motivation: LinuxSocket is not thread-safe and so we need to ensure we only access it from without the EventLoop thread. Modifications: Change EpollDatagramChannel to always dispatch to the EventLoop if not called from the EventLoop thread Result: No more threading issues
normanmaurer
force-pushed
the
eventloop_offload
branch
from
fb20441
to
f520061
Compare
|
Let me merge this so we can include it in the next release |
normanmaurer
added a commit
that referenced
this pull request
Jul 9, 2022
…in an EventLoop thread (#12584) Motivation: LinuxSocket is not thread-safe and so we need to ensure we only access it from without the EventLoop thread. Modifications: Change EpollDatagramChannel to always dispatch to the EventLoop if not called from the EventLoop thread Result: No more threading issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in an EventLoop thread
Motivation:
LinuxSocket is not thread-safe and so we need to ensure we only access it from without the EventLoop thread.
Modifications:
Change EpollDatagramChannel to always dispatch to the EventLoop if not called from the EventLoop thread
Result:
No more threading issues