Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct value from SSLSession.getPacketSize() when using nativ… #13095

Merged
merged 9 commits into from
Jan 9, 2023

Commits on Jan 4, 2023

  1. Return correct value from SSLSession.getPacketSize() when using nativ…

    …e SSL implementation
    
    Motivation:
    
    We didnt return the maximum size of SSL packet and tried to calculate it. This didnt work as SSL_max_seal_overhead(...) can only be used to calculate the maximum overhead for when encrypting ourself (and not the remote peer).
    Because of this we sometimes returned a smaller number then what is possible. This had the affect that when users did use getPacketSize() to size the ByteBuffer we could end up in a situation that would never produce a bug enough ByteBuffer and so never finish the handshake.
    
    This issue only accoured when users use the SSLEngine directly. When using our SslHandler we were not affected by this as we use a different approach there.
    
    Modifications:
    
    - Upgrade netty-tcnative to be able to reuse the the defined constant
    - Add unit test that did loop forever before this change
    
    Result:
    
    Fixes #13073
    normanmaurer committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    d4371b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Configuration menu
    Copy the full SHA
    7b17cf3 View commit details
    Browse the repository at this point in the history
  2. Remove assert

    normanmaurer committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    35e6d9e View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. compact or clear

    normanmaurer committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    533e712 View commit details
    Browse the repository at this point in the history
  2. checkstyle

    normanmaurer committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    0014b89 View commit details
    Browse the repository at this point in the history
  3. add assert back

    normanmaurer committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    323861b View commit details
    Browse the repository at this point in the history
  4. cleanup

    normanmaurer committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    9f617a4 View commit details
    Browse the repository at this point in the history
  5. checkstyle

    normanmaurer committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    d53f87a View commit details
    Browse the repository at this point in the history
  6. Use assume

    normanmaurer committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    a4cb7c0 View commit details
    Browse the repository at this point in the history