-
-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return correct value from SSLSession.getPacketSize() when using nativ… #13095
Merged
Commits on Jan 4, 2023
-
Return correct value from SSLSession.getPacketSize() when using nativ…
…e SSL implementation Motivation: We didnt return the maximum size of SSL packet and tried to calculate it. This didnt work as SSL_max_seal_overhead(...) can only be used to calculate the maximum overhead for when encrypting ourself (and not the remote peer). Because of this we sometimes returned a smaller number then what is possible. This had the affect that when users did use getPacketSize() to size the ByteBuffer we could end up in a situation that would never produce a bug enough ByteBuffer and so never finish the handshake. This issue only accoured when users use the SSLEngine directly. When using our SslHandler we were not affected by this as we use a different approach there. Modifications: - Upgrade netty-tcnative to be able to reuse the the defined constant - Add unit test that did loop forever before this change Result: Fixes #13073
Configuration menu - View commit details
-
Copy full SHA for d4371b0 - Browse repository at this point
Copy the full SHA d4371b0View commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7b17cf3 - Browse repository at this point
Copy the full SHA 7b17cf3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 35e6d9e - Browse repository at this point
Copy the full SHA 35e6d9eView commit details
Commits on Jan 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 533e712 - Browse repository at this point
Copy the full SHA 533e712View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0014b89 - Browse repository at this point
Copy the full SHA 0014b89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 323861b - Browse repository at this point
Copy the full SHA 323861bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f617a4 - Browse repository at this point
Copy the full SHA 9f617a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d53f87a - Browse repository at this point
Copy the full SHA d53f87aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4cb7c0 - Browse repository at this point
Copy the full SHA a4cb7c0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.