WebSocketClientProtocolHandler: add option to disable UTF8 validation #13265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of text frames Motivation: WebSocketClientProtocolHandler unconditionally adds UTF8 validation handler, even if one is not necessary (e.g. text frames are not used by application) Modification: add WebSocketClientProtocolConfig.withUTF8Validator option WebSocketClientProtocolHandler uses .withUTF8Validator option when adding Utf8FrameValidator to channel pipeline Result: configurable UTF8 validation of text frames payload in WebSocketClientProtocolHandler
normanmaurer
approved these changes
Mar 10, 2023
|
@mostroverkhov thanks a lot ! |
normanmaurer
pushed a commit
that referenced
this pull request
Mar 10, 2023
… of text frames (#13265) Motivation: WebSocketClientProtocolHandler unconditionally adds UTF8 validation handler, even if one is not necessary (e.g. text frames are not used by application) Modification: add WebSocketClientProtocolConfig.withUTF8Validator option WebSocketClientProtocolHandler uses .withUTF8Validator option when adding Utf8FrameValidator to channel pipeline Result: configurable UTF8 validation of text frames payload in WebSocketClientProtocolHandler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSocketClientProtocolHandler: add option to disable UTF8 validation of text frames.
Motivation:
WebSocketClientProtocolHandler unconditionally adds UTF8 validation handler, even if one is not necessary (e.g. text frames are not used by application).
Modification:
add WebSocketClientProtocolConfig.withUTF8Validator option.
WebSocketClientProtocolHandler uses .withUTF8Validator option when adding Utf8FrameValidator to channel pipeline.
Result:
configurable UTF8 validation of text frames payload in WebSocketClientProtocolHandler.