Release websocket handshake response if pipeline checks fail #13338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The WebSocketServerHandshaker require that either an HttpRequestDecoder or an HttpServerCodec exist in the pipeline. If they do not, we can't send a websocket handshake response. The handshake response is allocated prior to the pipeline checks. Therefor, if the checks fail, we need to release the response before returning the failed future. It might be possible to delay the allocation of the response until after the pipeline checks, but doing so breaks assumptions made by numerous tests. Modification: If the pipeline checks fail, release the handshake response before returning the failed promise. Result: We no longer leak a buffer in the handshake response if the pipeline checks fail.
|
Why are we even creating it before checking for pipeline configuration? |
|
@hyperxpro I do not know, but there were multiple test failures if I just moved it. |
normanmaurer
pushed a commit
that referenced
this pull request
Apr 20, 2023
Motivation: The WebSocketServerHandshaker require that either an HttpRequestDecoder or an HttpServerCodec exist in the pipeline. If they do not, we can't send a websocket handshake response. The handshake response is allocated prior to the pipeline checks. Therefor, if the checks fail, we need to release the response before returning the failed future. It might be possible to delay the allocation of the response until after the pipeline checks, but doing so breaks assumptions made by numerous tests. Modification: If the pipeline checks fail, release the handshake response before returning the failed promise. Result: We no longer leak a buffer in the handshake response if the pipeline checks fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The WebSocketServerHandshaker require that either an HttpRequestDecoder or an HttpServerCodec exist in the pipeline. If they do not, we can't send a websocket handshake response. The handshake response is allocated prior to the pipeline checks. Therefor, if the checks fail, we need to release the response before returning the failed future.
It might be possible to delay the allocation of the response until after the pipeline checks, but doing so breaks assumptions made by numerous tests.
Modification:
If the pipeline checks fail, release the handshake response before returning the failed promise.
Result:
We no longer leak a buffer in the handshake response if the pipeline checks fail.
Fixes #13337