Use network byte order when encoding ipv4 address and port for Socks codecs #13427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Socks encoders do not always use network byte order when encoding port resulting in connection errors when buffer's order is little endian Modifications: Use ByteBufUtil.writeShortBE to make sure the right byte order is used Result: Socks messages are now using the right encoding.
Motivation: Socks decoders do not always use network byte order when decoding ipv4 address and port resulting in connection errors when buffer's order is little endian Modifications: Add readIntBE readUnsignedShortBE to SocksCommonUtils in order to read data properly Result: Socks messages are now decoded properly
normanmaurer
requested changes
Jun 6, 2023
codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCommonUtils.java
Outdated
Show resolved
Hide resolved
chrisvest
reviewed
Jun 6, 2023
codec-socks/src/main/java/io/netty/handler/codec/socks/SocksCommonUtils.java
Outdated
Show resolved
Hide resolved
|
@laurentgo did you sign our ICLA yet ? https://netty.io/s/icla |
I just did |
normanmaurer
requested changes
Jun 7, 2023
codec-socks/src/test/java/io/netty/handler/codec/socks/SocksCmdRequestTest.java
Outdated
Show resolved
Hide resolved
chrisvest
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Socks codecs do not always use network byte ordering when encoding/decoding socks messages resulting in connection issues
Modification:
Use BE methods to properly read/write socks messages
Result:
Fixes #13426