Release DnsRecords when failing to notify promise #13437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed this while working on something else... That said this is more of a "correct usage" fix. As we used wrapped ByteBufs there would be no "real leak" even without this fix. |
Motivation: We need to release the DnsRecords if we didnt transfer ownership to prevent leaks. Modifications: Release DnsRecords when trySuccess(...) returns false Result: Correctly release reference counted resources
normanmaurer
force-pushed
the
leak_on_notify_failure
branch
from
fff6a10
to
5209e9a
Compare
violetagg
approved these changes
Jun 13, 2023
normanmaurer
added a commit
that referenced
this pull request
Jun 13, 2023
Motivation: We need to release the DnsRecords if we didnt transfer ownership to prevent leaks. Modifications: Release DnsRecords when trySuccess(...) returns false Result: Correctly release reference counted resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to release the DnsRecords if we didnt transfer ownership to prevent leaks.
Modifications:
Release DnsRecords when trySuccess(...) returns false
Result:
Correctly release reference counted resources