Add support for snappy http content encoding #13529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xingrufei <qhdxssm@qq.com>
Signed-off-by: xingrufei <qhdxssm@qq.com>
Signed-off-by: xingrufei <qhdxssm@qq.com>
Signed-off-by: xingrufei <qhdxssm@qq.com>
franz1981
reviewed
Aug 6, 2023
codec-http/src/main/java/io/netty/handler/codec/http/HttpContentCompressor.java
Outdated
Show resolved
Hide resolved
normanmaurer
requested changes
Aug 16, 2023
| * {@link SnappyOptions} holds config for | ||
| * Snappy compression. | ||
| */ | ||
| public class SnappyOptions implements CompressionOptions { |
There was a problem hiding this comment.
Suggested change
| public class SnappyOptions implements CompressionOptions { | |
| public final class SnappyOptions implements CompressionOptions { |
| @Test | ||
| public void snappyEncodingSingleEmptyMessage() throws Exception { | ||
| final String text = ""; | ||
| final ByteBuf data = Unpooled.copiedBuffer(text.getBytes()); |
There was a problem hiding this comment.
Suggested change
| final ByteBuf data = Unpooled.copiedBuffer(text.getBytes()); | |
| final ByteBuf data = Unpooled.copiedBuffer(text.getBytes(CharsetUtil.US_ASCII)); |
| @Test | ||
| public void snappyEncodingSingleMessage() throws Exception { | ||
| final String text = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbccccccccccccccccccccccc"; | ||
| final ByteBuf data = Unpooled.copiedBuffer(text.getBytes(CharsetUtil.UTF_8.name())); |
There was a problem hiding this comment.
Suggested change
| final ByteBuf data = Unpooled.copiedBuffer(text.getBytes(CharsetUtil.UTF_8.name())); | |
| final ByteBuf data = Unpooled.copiedBuffer(text.getBytes(CharsetUtil.US_ASCII))); |
skyguard1
force-pushed
the
add_snappy_http_encoding
branch
from
058312e
to
b87b8f8
Compare
|
@skyguard1 thanks a lot |
|
It is my pleasure |
normanmaurer
pushed a commit
that referenced
this pull request
Aug 17, 2023
Motivation: Since netty already supports the decompression of snappy's http content encoding, it should also consider supporting snappy's http content compression Modification: Add support for snappy http content encoding Result: Netty supports snappy http content encoding --------- Signed-off-by: xingrufei <qhdxssm@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Since netty already supports the decompression of snappy's http content encoding, it should also consider supporting snappy's http content compression
Modification:
Add support for snappy http content encoding
Result:
Netty supports snappy http content encoding