Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for snappy http2 content decompression #13530

Merged

Conversation

skyguard1
Copy link
Contributor

Motivation:

Since netty already supports the decompression of snappy's http content encoding, it should also consider supporting snappy's http2 content decompression

Modification:

Add support for snappy http content decompression

Result:

Netty supports snappy http content decompression

@normanmaurer
Copy link
Member

@skyguard1 can you add some unit tests ?

@skyguard1
Copy link
Contributor Author

@normanmaurer I think io.netty.handler.codec.http2.DataCompressionHttp2Test.snappyEncodingSingleMessage() has tested it. Do we need other test cases to test snappy http2 content decompression?

Signed-off-by: xingrufei <qhdxssm@qq.com>
@normanmaurer normanmaurer added this to the 4.1.97.Final milestone Aug 17, 2023
@normanmaurer normanmaurer merged commit 64c8983 into netty:4.1 Aug 18, 2023
14 checks passed
@normanmaurer
Copy link
Member

@skyguard1 thanks

@skyguard1
Copy link
Contributor Author

It is my pleasure

@skyguard1 skyguard1 deleted the add_support_snappy_http2_content_encoding branch August 18, 2023 11:11
normanmaurer pushed a commit that referenced this pull request Aug 18, 2023
Motivation:

Since netty already supports the decompression of snappy's http content
encoding, it should also consider supporting snappy's http2 content
decompression

Modification:

Add support for snappy http content decompression

Result:

Netty supports snappy http content decompression

---------

Signed-off-by: xingrufei <qhdxssm@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants